branch-4.1: [fix](load) fix load_to_single_tablet routing for auto partition #64356#64455
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](load) fix load_to_single_tablet routing for auto partition #64356#64455github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
) ### What problem does this PR solve? `load_tablet_idx` is used by random distribution routing. For normal random loads it can advance across batches, but for `load_to_single_tablet=true` it must remain fixed for the partition in the sink so all rows are routed to one tablet. For normally planned partitions this is stable because FE builds the sink plan once and all BE sink instances receive the same `load_tablet_idx`. For runtime auto partitions, each BE can independently call `createPartition()` or `replacePartition()` for the same txn and partition. Before this patch, the auto partition cache only stored tablet locations and did not store `load_tablet_idx`. FE also did not know whether the caller was using `load_to_single_tablet`, so runtime auto partitions could lose the single-tablet routing semantics or compute different tablet indexes across BE RPCs. This patch passes `load_to_single_tablet` in create/replace partition RPCs and stores the selected `load_tablet_idx` in `AutoPartitionCacheManager`. Later BE RPCs for the same txn and partition reuse the cached tablet index together with the cached tablet locations. Ordinary random loads are unchanged.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64356