Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrequentLongsSketch.getInstance(String)builds the hash map from the length and numActive tokens in the string without checking either against the map. The probe loops inReversePurgeLongHashMap(adjustOrPutValue,hashProbe) only stop at an empty slot, and the only guard is anassert, so once every slot is taken a probe for a new key spins forever.getInstance("1,10,3,0,3,0,3,2,1,1,2,1,3,1")never returns, and an empty image that claims a map length of 2 ("1,10,3,5,0,0,0,2") deserializes fine but hangs on the third distinctupdate(), becausecurMapCapis computed from the 8-slot minimum while the map only has 2 slots. With assertions off this is an unbounded CPU loop from a ~30 byte input in any service that deserializes sketch strings it receives.Reject a map length below
1 << LG_MIN_MAP_SIZEand a numActive outside[0, capacity]ingetInstance(String), next to the existing "Possible Corruption" checks.serializeToString()never produces either, so valid images are unaffected; theMemorySegmentpath already goes throughupdate()and resizes/purges, so it does not need the same check. Added two tests toLongsSketchTest(with a timeout so a regression fails instead of hanging the suite);mvn clean verifypasses.