Persistent transparency + getStatusBarHeight method - #96
Conversation
…tus bar again + support pre-configured `StatusBarOverlaysWebView` parameter from `config.xml`
…on Android only at the moment)
|
I can confirm your By the way, setting We noticed that if we changed this value to Please merge this Apache. This is great work. |
|
Hey @aszmyd , this looks like a great PR. Could you maybe invest the time to make separate PRs for the separate features? Would be much easier to merge and be sure that stuff can be undone if needed. @Exilz Thanks for your comment. The commit you linked to, is this fixing a bug that is currently present? Should there be a PR for this plugin that adopts these changes? If so, would you be kind enough to create one? Thanks! |
|
I'm closing this one as two separate PR has been made for it. |
Platforms affected
Android
What does this PR do?
overlaysWebView(true),hide(),show()the status bar gets shown without transparency and pushes webview to bottom. And because we wanted to have statusbar transparent (overlaysWebView) from this point the show/hide should toggle the statusbar visibility and it should always show transparent.StatusBarOverlaysWebViewin Android when its pre-defined in projectconfig.xmlStatusBar.getStatusBarHeightmethod (Android only) that gets current statusbar height in CSS pixelsWhat testing has been done on this change?
Manual testing on Android device