WIP: Add resource-based alert rules with evaluation engine, event bus integration, and UI by Damans227 · Pull Request #13478 · apache/cloudstack

Damans227 · 2026-06-23T18:54:49Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Damans227 · 2026-06-23T18:55:21Z

@blueorangutan package

blueorangutan · 2026-06-23T18:56:05Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-23T18:57:11Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 18352

Damans227 · 2026-06-23T19:02:07Z

@blueorangutan package

blueorangutan · 2026-06-23T19:04:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-06-23T19:11:08Z

Codecov Report

❌ Patch coverage is 40.35801% with 733 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.94%. Comparing base (602d9ec) to head (ab4d7f3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...dstack/resourcealert/ResourceAlertManagerImpl.java	50.26%	128 Missing and 60 partials ⚠️
...dstack/resourcealert/ResourceAlertServiceImpl.java	48.34%	141 Missing and 31 partials ⚠️
...ck/resourcealert/dao/ResourceAlertRuleDaoImpl.java	0.00%	67 Missing ⚠️
...dstack/resourcealert/dao/ResourceAlertDaoImpl.java	0.00%	53 Missing ⚠️
...t/api/command/user/CreateResourceAlertRuleCmd.java	0.00%	28 Missing ⚠️
...tack/resourcealert/vo/ResourceAlertRuleJoinVO.java	0.00%	28 Missing ⚠️
...t/api/command/user/UpdateResourceAlertRuleCmd.java	0.00%	25 Missing ⚠️
...urcealert/dao/ResourceAlertRuleWebhookDaoImpl.java	0.00%	22 Missing ⚠️
...che/cloudstack/mom/webhook/WebhookServiceImpl.java	70.83%	21 Missing ⚠️
...oudstack/resourcealert/vo/ResourceAlertRuleVO.java	58.33%	19 Missing and 1 partial ⚠️
... and 11 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13478      +/-   ##
============================================
+ Coverage     19.91%   19.94%   +0.03%     
- Complexity    20200    20340     +140     
============================================
  Files          6373     6398      +25     
  Lines        577230   578514    +1284     
  Branches      70696    70921     +225     
============================================
+ Hits         114974   115404     +430     
- Misses       449690   450451     +761     
- Partials      12566    12659      +93

Flag	Coverage Δ
uitests	`3.70% <ø> (-0.01%)`	⬇️
unittests	`21.22% <40.35%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-06-23T19:58:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18353

Damans227 · 2026-06-24T02:02:59Z

@blueorangutan package

blueorangutan · 2026-06-24T02:04:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-24T03:00:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18355

Damans227 · 2026-06-24T16:45:51Z

@blueorangutan package

blueorangutan · 2026-06-24T16:48:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-24T17:42:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18371

github-actions · 2026-06-29T21:45:46Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

- Introduced ResourceAlertResponse and ResourceAlertRuleResponse classes for API responses. - Created ResourceAlertDao and ResourceAlertDaoImpl for handling resource alert data. - Implemented ResourceAlertRuleDao and ResourceAlertRuleDaoImpl for managing alert rules. - Added ResourceAlertRuleJoinDao and ResourceAlertRuleJoinDaoImpl for joining alert rules with additional data. - Defined ResourceAlertVO and ResourceAlertRuleVO for representing alert and rule entities. - Configured Spring context for resource alerts in spring-resource-alerts-context.xml. - Added module properties for resource alerts in module.properties.

… and enhance unit tests for email notifications

… opted-out resources

…t rules configuration

Damans227 · 2026-09-23T14:12:20Z

@blueorangutan package

… tree or own account

… for parameter names

Damans227 · 2026-09-23T14:45:01Z

@blueorangutan package

blueorangutan · 2026-09-23T17:50:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19312

blueorangutan · 2026-09-23T17:53:28Z

[SF] Trillian Build Failed (tid-17031)

blueorangutan · 2026-09-23T18:32:42Z

[SF] Trillian Build Failed (tid-17032)

blueorangutan · 2026-09-23T18:59:48Z

[SF] Trillian Build Failed (tid-17033)

blueorangutan · 2026-09-23T19:44:06Z

[SF] Trillian Build Failed (tid-38)

blueorangutan · 2026-09-23T20:06:57Z

[SF] Trillian Build Failed (tid-39)

blueorangutan · 2026-09-23T22:03:44Z

[SF] Trillian Build Failed (tid-41)

…ce names in UI

github-actions · 2026-09-24T11:13:05Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

boring-cyborg Bot added component:build component:UI labels Jun 23, 2026

Damans227 force-pushed the resource-alerts branch from 17b9459 to bf05e6c Compare June 23, 2026 19:01

weizhouapache added this to the 4.24.0 milestone Jun 29, 2026

github-actions Bot added the status:has-conflicts label Jun 29, 2026

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland moved this from Backlog to conflict/waiting for author in CloudStack Testing Aug 31, 2026

Damans227 added 8 commits September 23, 2026 10:07

Implement Resource Alerts Manager and related components

fea6282

Add unit tests for Resource Alerts functionality

3f80c77

Implement email notification feature in Resource Alert Manager

01820bf

Refactor ResourceAlertManagerImpl to extract publishAlertEvent method…

8e1af58

… and enhance unit tests for email notifications

Add Resource Alerts functionality with UI components and localization

92b6f64

Implement resource alert rules limit and enhance evaluation logic for…

6f8154d

… opted-out resources

Change alert icon from AlertOutlined to BellOutlined in resource aler…

21e9155

…t rules configuration

Damans227 added 2 commits September 23, 2026 10:08

Add volume size metric to resource alerts

6d0cc21

Add storage pool used IOPS metric to resource alerts

d1a357c

Damans227 force-pushed the resource-alerts branch from 505b120 to d1a357c Compare September 23, 2026 14:11

Damans227 added 8 commits September 23, 2026 10:22

Target resource alerts at 24.0.0 after rebase

7687e51

Scope generic resource alert rules by owner role: whole cloud, domain…

4342d97

… tree or own account

Evaluate resource alert rules on a single management server

d492303

Remove old fired resource alerts and page listResourceAlerts

5687dd0

Remove resource alert rules whose owner or resource no longer exists

b279b54

Record audit events for resource alert rule create, update and delete

5ef0312

Move resource alert commands to the user package and use ApiConstants…

f04a09c

… for parameter names

Validate resource alert rule thresholds and reset interval

aee3036

github-actions Bot removed the status:has-conflicts label Sep 23, 2026

boring-cyborg Bot added component:api component:storage labels Sep 23, 2026

Damans227 added 4 commits September 23, 2026 18:44

Apply webhook delivery security settings to alert deliveries

5b15924

Log alert webhook deliveries that fail inside the delivery thread

ab4d7f3

Return resource name in resource alert rule and alert responses

54d2321

Add resource and owner pickers to resource alert form and show resour…

532eef7

…ce names in UI

github-actions Bot added the status:has-conflicts label Sep 24, 2026

Round metric values in resource alert tables

b3301b3

Conversation

Damans227 commented Jun 23, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Damans227 commented Jun 23, 2026

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

Damans227 commented Jun 23, 2026

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

codecov Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

Damans227 commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

Damans227 commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

Damans227 commented Sep 23, 2026

Uh oh!

Damans227 commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

blueorangutan commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jun 23, 2026 •

edited

Loading