Add unlimited reference-driven MXF repair and reindexing - #294
Open
jpooley-hearst wants to merge 4 commits into
Open
Add unlimited reference-driven MXF repair and reindexing#294jpooley-hearst wants to merge 4 commits into
jpooley-hearst wants to merge 4 commits into
Conversation
jpooley-hearst
marked this pull request as ready for review
August 5, 2026 18:23
Owner
|
Hi, thank you for the PR. Could you please follow the coding style of the project in mxf.cpp? And it would be nice if you could merge the docs from MXF_REFERENCE_REPAIR_PROPOSAL.md into mxf.cpp. Optimally documenting the code too. Perhaps at the top of the file a longer comment could be placed giving some "meta info". Are there any references you used to figure out the file format? If so it would be nice to mention them (e.g. URLs etc). If you figured them out yourself, would also be worth noting IMO. |
Author
|
Addressed in 9137314.
Validation run locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
-mxfrepair using a compatible known-good MXF referenceWhy
Interrupted broadcast and camera MXF recordings can retain usable essence while losing header, footer, index, or RIP metadata. MXF is KLV-based rather than atom-based, so this introduces a separate bounded streaming repair path while retaining untrunc's known-good-reference workflow.
Validation
make -j2UNTRUNC=./untrunc tests/test-mxf-reference-repair.sh