Repository navigation
Conversation
There was a problem hiding this comment.
2 optional suggestions (nits or notes on pre-existing code) were found and not posted.
The latest push brings back an issue flagged in an earlier review; replied in that comment's thread.
Still open from earlier reviews (2):
- 🔴
clinical-trial-forecast/scripts/ft_model.py:180—A failed revise round can be published as the final model, pairing round 1's numbers with round 2's parameter sheet. cm… - 🔴
clinical-trial-forecast/scripts/ft_registry.py:178—Files-only runs can build the forecast on the oldest attached trials and silently drop the recent ones. When more attac…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
…ases Name the open binder generators that the guide left out: RFdiffusion3, RFD4-Proteina, PXDesign, BoltzGen, Proteina-Complexa and the ESM cookbook's gradient-guided design through ESMFold2. List the public kit release's kits that matter for this guide, explain its four modes, and ask for one mode across controls and candidates. Say that weights come from their providers under their own terms. Date the release (17 September 2026) and say it had not changed by 27 October 2026. Say to begin with one session, one GPU and a fixed time budget, citing the September 2026 research post. Warn that a generator which optimises against a structure predictor makes that predictor part of the objective. Add a troubleshooting row for a kit that prints NOT ACTIVE and exits with code 3. The rubric's reference points (measured 22 September 2026) are unchanged.
…2 kit Optional. A long-running process of the public ESMFold2 kit in fast mode can occasionally exit with a CUDA error. Say what it looks like and what to do: re-run the lost inputs, fold fewer inputs per process, or set EF2_GRAPH_CAPTURE=0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two skills: clinical-trial-forecast estimates a registered trial's probability of success, and binder-gauntlet designs and checks de novo miniprotein binders. Also restores the top-level README.