Expose configurable grouping token limit - #899
Open
RamiNoodle733 wants to merge 5 commits into
Open
RamiNoodle733 wants to merge 5 commits into
RamiNoodle733 wants to merge 5 commits into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #841.
Adds a public
sqlparse.set_max_grouping_tokens()API so applications can raise, lower, or disable the grouping-stage token cap without importing and mutating an internal module global directly.The setter accepts a positive integer or
None, rejects invalid values such as booleans, non-integers, zero, and negatives, and applies process-wide to subsequent parsing and formatting operations. The docstring explicitly warns that disabling or increasing the guard is not recommended for untrusted SQL.Targeted regression coverage verifies that lowering the limit changes parser behavior,
Nonedisables the token-count guard, invalid values are rejected, the original global limit is restored after each test, and the same configured guard is enforced throughsqlparse.format().Duplicate consolidation: #892 was an accidental overlapping implementation for the same #841 root cause and has been closed in favor of this canonical PR. Earlier #874 was already closed.
Validation: branch diff is limited to the public setter/export, its safety documentation, and focused tests. The full pytest suite was not run locally because this automation environment does not have a runnable repository checkout, so no local test-suite result is claimed.