Allow custom lexer instances on FilterStack - #896
Closed
RamiNoodle733 wants to merge 1 commit into
Closed
RamiNoodle733 wants to merge 1 commit into
RamiNoodle733 wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterStack.run()currently calls the module-levellexer.tokenize(), which always resolves to the global defaultLexer. That prevents callers from reusing the normal filter/splitting/grouping pipeline with a separately configured lexer instance.This change stores the default lexer on each
FilterStackand hasrun()call that instance directly. Existing callers keep the same default behavior, while advanced callers can now replacestack.lexerwith a customLexerinstance as proposed in #806.A focused regression test injects a custom lexer and verifies that its token stream is what the stack processes.
Closes #806
Checks
pytest) because the execution environment could not clone GitHub to run the repository suite locallyruff) because ruff was not available against a local checkoutpython -m py_compilepassed for both changed Python files