Repository navigation
Fix rust overlay snapshot hash - #26
andersaamodt wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
|
||
| inherit src; | ||
| cargoLock.lockFile = ../Cargo.lock; | ||
|
|
There was a problem hiding this comment.
[P1] Provide cargoHash so the Nix build can vendor dependencies
The new nix/standalone.nix derivation invokes rustPlatform.buildRustPackage with a Cargo.lock but no cargoHash (or cargoSha256). buildRustPackage requires the hash of the vendored cargo dependencies; without it nix-build nix/standalone.nix fails at evaluation with “attribute ‘cargoHash’ missing” and the “Build NixOS standalone binary” step in the workflow will always error. Add the correct cargo hash to allow the standalone build to succeed.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68dbab15e71c8320a748455d60820d9b