Skip to content

Fix rust overlay snapshot hash - #26

Open
andersaamodt wants to merge 1 commit into
mainfrom
codex/restore-nixos-standalone-binary-h63pgo
Open

andersaamodt wants to merge 1 commit into
mainfrom
codex/restore-nixos-standalone-binary-h63pgo

Conversation

@andersaamodt

Copy link
Copy Markdown
Owner

Summary

  • update the oxalica rust-overlay snapshot hash so the pinned toolchain can be fetched during the standalone build

Testing

  • cargo test --locked

https://chatgpt.com/codex/tasks/task_e_68dbab15e71c8320a748455d60820d9b

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread nix/standalone.nix
Comment on lines +30 to +33

inherit src;
cargoLock.lockFile = ../Cargo.lock;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Provide cargoHash so the Nix build can vendor dependencies

The new nix/standalone.nix derivation invokes rustPlatform.buildRustPackage with a Cargo.lock but no cargoHash (or cargoSha256). buildRustPackage requires the hash of the vendored cargo dependencies; without it nix-build nix/standalone.nix fails at evaluation with “attribute ‘cargoHash’ missing” and the “Build NixOS standalone binary” step in the workflow will always error. Add the correct cargo hash to allow the standalone build to succeed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant