Repository navigation
Fix nixpkgs hash for standalone build - #25
andersaamodt wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - name: Build NixOS standalone binary | ||
| run: | | ||
| nix-build nix/standalone.nix --out-link result-nixos | ||
| mkdir -p artifacts | ||
| cp -L result-nixos/bin/stonr artifacts/stonr-nixos-amd64 |
There was a problem hiding this comment.
[P1] Bundle full Nix closure for uploaded binary
The workflow step copies only result-nixos/bin/stonr into the artifact. Binaries produced by nix-build embed RPATHs to libraries in /nix/store/<hash>-…; when the artifact is downloaded on another machine (even another NixOS host) those store paths will not exist unless the entire closure is copied as well. The uploaded file will therefore fail to start with missing dynamic loader or library errors. Consider exporting the whole derivation output (e.g. nix-store --export $(nix-store -qR result-nixos)) or using nix bundle/nix copy so the artifact contains its dependencies.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68dbab15e71c8320a748455d60820d9b