Skip to content

fix(stamp): font-path hardening — unresolvable /Resources references and direct-dict /Font entries #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjcoles merged 5 commits into from
Jul 9, 2026
Merged

fix(stamp): font-path hardening — unresolvable /Resources references and direct-dict /Font entries #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b12810
fix(stamp): error on unresolvable /Resources references in ensure_font
alexjcoles Jul 8, 2026
970e661
fix(stamp): find direct-dictionary /Font entries in font lookup
alexjcoles Jul 8, 2026
98f4c46
test(stamp): pin malformed direct /Font repair and document the asymm…
alexjcoles Jul 8, 2026
411b05f
refactor(stamp): extract require_dict and share the Phase-1 /Resource…
alexjcoles Jul 8, 2026
3bf328b
test(stamp): extract page_font_dict helper and tighten walk-Err pins
alexjcoles Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ doc.apply_visible_stamps({

Raises `ArgumentError` if the config hash cannot be deserialized, and `RuntimeError` if a stamp cannot be applied (e.g. a font cannot be registered into a page's `/Resources`) — discard the document on error rather than saving it.

`/Font` inside a page's `/Resources` is handled as either a direct dictionary or an indirect reference (both legal per ISO 32000 §7.8.3); a `/Font` reference that does not resolve to a dictionary raises rather than silently leaving the stamp text unrendered. Fonts registered on a page with inherited (parent-level) resources never mutate the shared parent dictionaries — the page gets its own resources copy.
`/Font` inside a page's `/Resources` is handled as either a direct dictionary or an indirect reference (both legal per ISO 32000 §7.8.3), and entries inside it are found whether stored as references or direct dictionaries; a `/Font` reference that does not resolve to a dictionary raises rather than silently leaving the stamp text unrendered. A `/Resources` entry that is an unresolvable indirect reference — on the page itself or on a `/Parent` ancestor consulted for inheritance — also raises, rather than being silently replaced or skipped over. Fonts registered on a page with inherited (parent-level) resources never mutate the shared parent dictionaries — the page gets its own resources copy.

Colour channels outside 0.0–1.0 are clamped into range (DeviceRGB operands must be in [0.0, 1.0] per the PDF spec).

Expand Down
Loading