You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see the last commit time is 2022 year, so I asked this.
Recently I found 2 problem when I test this repo and pip package.
After [pip install ], it create [src] directory in site-packages, src is a no meaning name, import it use import src is not fit.
Modules import in source file are relative mode, I does not think this is a good way.
Base above, i asked it.
Fix them need change it's package structure and relative mode.
I hope I can join and maintain it. Can you accept this change about package structure and some what.
Activity
amalfra commentedon Aug 3, 2023
Yes, this will be maintained.
tinymahua commentedon Aug 4, 2023
I see the last commit time is 2022 year, so I asked this.
Recently I found 2 problem when I test this repo and pip package.
Base above, i asked it.
Fix them need change it's package structure and relative mode.
I hope I can join and maintain it. Can you accept this change about package structure and some what.
amalfra commentedon Aug 13, 2023
@tinymahua https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ is a description of src layouts. It's a standard layout and since we don't want code to be used src layout works best.
tinymahua commentedon Aug 24, 2023
I agreen src layouts. I mean that it need a main package named docker_hub in src directory. And then set the setup.py target the installed packages.
Now code structure will happen a problem after pip install:
In my project, I use docker_hub need do:
from src.libs.xxx import yyy
Normal import statements should above：
from docker_hub.xxxx import yyy
Perhaps I desc not enough before, after a few time, I commit a PR, hope think it, thanks.