Repository navigation
Conversation
…CONTRIBUTING.md (#26)
* CI: lean fork CI (fmt, clippy, nextest, wasm) for dev/signex with one required summary check * Format and lint fork-only code so Fork CI starts green rustfmt and clippy fixes, limited to lines the fork added (upstream master is already fmt/clippy clean, so no upstream line changes and syncs stay conflict-free). Files: core/window direction and monitor, tiny_skia and wgpu geometry/compositor, radio, toggler, winit. * Docs: formatting rule that keeps upstream syncs conflict-free * Docs: fork contributing guide in .github/CONTRIBUTING.md; root CONTRIBUTING.md back to upstream GitHub shows .github/CONTRIBUTING.md first, so the fork's rules (GitHub issues and Discussions, no Zulip) are what contributors see, and the root file stays identical to upstream so syncs never conflict on it. * CI: cache the apt packages (gtk for rfd) instead of installing them on every run
…p docs) for alpha.4 (#51) * Add `table_width` setting to `markdown` widget Add `Settings::table_width` to cap table scrolling Tables are wrapped in an unbounded horizontal `scrollable`, lifting the width limit of their contents (`Limits::infinite`), so cell text never wraps and tables scroll like `<nobr>` blocks regardless of container width. Add `Settings::table_width: Option<Length>` (`None` preserves current behavior). When set, a private `CappedTable` widget restores a width limit at layout time: clearing the `infinite` flag lets cell text wrap and fit, while the horizontal scroll remains an escape hatch for content wider than the cap. `cap_width` resolves the setting against the available parent width: fit/fill lengths wrap at the parent width; fixed/bounded lengths keep their own bounds so wide tables keep scrolling. * fix: set sensor widget distance to 0 when visible * fix: sensor only emits `on_show` once if `on_hide` is `None` - If no `on_hide` is set, then the sensor was only emitting `on_show` once, the first time it popped into view. After that, if it popped out of view the `has_popped_in` variable wasn't being set to `false` so it thought the sensor was always in view and never emitted the `on_show` again. * fix: enable text selection inside `pane_grid` Selecting text with `.selectable(true)` did not work inside panes due to `shell.capture_event()` swallowing the event when cursor was within bounds. * feat: add window blur support for Windows (Acrylic Background) * Clear the cached selection when highlighting re-shapes lines Editor::highlight() re-shapes lines with new attributes (e.g. bold) via shape_as_needed, but the cached selection still holds the caret position computed from the previous, unstyled layout, so the caret is drawn at the wrong x-offset until the next perform() clears the cache. Clear it after re-shaping, as the other mutators (perform, move_to, update) already do. * Fix text selection offset in `checkbox` label * Add Escape key to reset the image viewer * Fix Rectangle::chord endpoint distance for diagonal angles Compute the half-length as the minimum of the ray intersection distances with the rectangle slabs instead of the maximum of the projected half-extents This puts both endpoints on the boundary for non-axis-aligned angles and leaves axis-aligned chords unchanged * Merge upstream iced-rs#3393: draw SVG texts with the iced fontdb Applied as a squashed diff (the PR branch carries only master-sync merges). The svg feature now also enables iced_renderer/svg-text. * FORK.md: record second batch of upstream PRs * Fix markdown CappedTable for this tree's Widget/Element API (PR 3494 port) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CadiceyBxudk4jCHHzTWEx * Docs: FORK.md alpha.3 section and release draft Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CadiceyBxudk4jCHHzTWEx * Docs: gap analysis of iced for Signex (29 verified gaps, 17 issues) Eight read-only area surveys, 30 adversarial verifications, 60 candidates. No P0/P1 after verification; see the report for evidence, upstream status, proposals, refuted candidates and the suggested roadmap. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CadiceyBxudk4jCHHzTWEx * Docs: gap analysis, Focusable is also implemented by combo_box Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CadiceyBxudk4jCHHzTWEx * Fix monitor size scaling and primary-monitor flagging (fixes #49, #50) MonitorData::size() multiplied the physical size by the scale factor instead of dividing, and monitor_list compared the primary handle with itself so every monitor was flagged primary. Both now have unit tests. cargo check --workspace --all-targets is clean; iced_core and iced_winit tests for the touched code pass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CadiceyBxudk4jCHHzTWEx * Format fork-added code from the alpha.4 ports (markdown CappedTable, pane_grid, monitor tests) * Image viewer: Escape resets and is captured only when hovered or changed, with tests * Docs: alpha.4 release draft breaking changes, #49 wording, known gaps, viewer deviation * Docs: drop stale iced_winit not-run gap * Pin #50 through the monitor list builder; docs: Signex impact, size() note, stale notes --------- Co-authored-by: stiff <v.stiff@gmail.com> Co-authored-by: alex-ds13 <145657253+alex-ds13@users.noreply.github.com> Co-authored-by: Osma S. Rautila <44613540+xosxos@users.noreply.github.com> Co-authored-by: Polesznyák Márk <contact@pml68.dev> Co-authored-by: Benoit Brummer (Trougnouf) <trougnouf@disroot.org> Co-authored-by: Wleeaf <179125857+wleeaf@users.noreply.github.com> Co-authored-by: Gaurav Atreya <allmanpride@gmail.com> Co-authored-by: akasakariko <148060537+akasakariko@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
devintosignexfor theiced-signex-v0.15.0-alpha.4tag.Changes since alpha.3 (
56ac1a293):dev. It brings upstream ports (3513, 3521, 3505, 3529, 3393, 3179, 3220, 3139, 3522, 3494) plus the fork fixes MonitorData::size() multiplies by the scale factor instead of dividing #49 (Monitor::size()now logical) and winit::conversion::monitor_list marks every monitor as primary #50 (only the real primary monitor is flagged primary). Adversarial and regression reviews both approved the final head1c70979a7;dev's tree is identical to it.fork-ci · required) and the contributing guide (fixes [F] Fork CI: lean workflow for dev/signex, upstream workflows disabled #30, fixes [F] Contributing guide: fork rules, GitHub issues/Discussions instead of Zulip #31).Release notes, breaking changes and the Signex impact (SVG icons with
<text>start drawing their labels) are inRELEASE-iced-signex-v0.15.0-alpha.4.md.Merge with a merge commit, not a squash, so
devandsignexshare history. Tag the merge commit afterwards.