Skip to content

Add SURF and BRISK feature types - #702

Draft
fabiencastan wants to merge 1 commit into
alicevision:developfrom
leviresende:leviresende-patch-1
Draft

fabiencastan wants to merge 1 commit into
alicevision:developfrom
leviresende:leviresende-patch-1

Conversation

@fabiencastan

Copy link
Copy Markdown
Member

Description

Add implementation of new feature types: SURF and BRISK.

Features list

  • new feature type SURF
  • new feature type BRISK

Implementation remarks

Integration of algorithms implemented in OpenCV.

@fabiencastan

Copy link
Copy Markdown
Member Author

@leviresende let us know when it's ready for testing and review.

@leviresende

leviresende commented Oct 13, 2019

Copy link
Copy Markdown

@fabiencastan for sure! I'm facing some troubles, as soon as possible I'll give you a feedback

@natowi natowi added the feature label Nov 20, 2019
@riccardogiorato

Copy link
Copy Markdown

Any news @leviresende ? How much faster are to calculate these types? Can you provide a side to side comparison with the current features?

@leviresende

leviresende commented Feb 11, 2020 via email

Copy link
Copy Markdown

@fabiencastan

Copy link
Copy Markdown
Member Author

@leviresende : We get a lot of questions and it's difficult to keep track of all the discussions. It's better to keep the maximum of them on github where we have the history, etc. I'm sorry if I missed to answer to you!
Do you plan to finalize this PR?

@leviresende

Copy link
Copy Markdown

As we've chatted before, the issue that I had was to compile the Meshroom. Give me a couple of days, I'll change my strategy to do this task. Whether I have any problem I'll post here, but please, be available.

@fabiencastan

Copy link
Copy Markdown
Member Author

@leviresende Sorry if I missed to answer to an email, it was not intentional!

@natowi

natowi commented Mar 14, 2020

Copy link
Copy Markdown
Member

@leviresende

the issue that I had was to compile the Meshroom

If you need help, feel free to ask.

I tried to finalize this PR myself, using this 01f9d52 as guideline, but I must have missed something as it did not work, so your continuation would be much appreciated.

@natowi natowi changed the title Add SURF and BRISK feature types [WIP] Add SURF and BRISK feature types Mar 14, 2020
@fabiencastan
fabiencastan marked this pull request as draft April 11, 2020 14:26
@fabiencastan fabiencastan changed the title [WIP] Add SURF and BRISK feature types Add SURF and BRISK feature types Sep 3, 2020
@github-actions github-actions Bot added the stale label Jun 12, 2022
@github-actions github-actions Bot closed this Jun 19, 2022
@vic4key

vic4key commented Apr 26, 2024

Copy link
Copy Markdown

Thank @leviresende for working on this.
Please merge this feature @fabiencastan.
These algorithms might better for several cases. But why no one merge this PR?
P.S Sorry for pulling this thread up after a long time. But these algorithms might better for several cases. It should be merged.

@natowi natowi reopened this Oct 12, 2024
@github-actions github-actions Bot removed the stale label Oct 13, 2024
@github-actions github-actions Bot added the stale label Oct 8, 2025
@github-actions github-actions Bot closed this Oct 15, 2025
@fabiencastan fabiencastan reopened this Oct 15, 2025
@github-actions github-actions Bot removed the stale label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants