chore: refresh threats/fort_status goldens against current fixture image - #97
Merged
Merged
Conversation
The committed goldens (last authored 2026-07-21) still showed a
5-strong great-danger group ("Monster Of Vomit", DEMON_19) that no
longer exists in the currently-built df-headless:53.15 fixture image's
world state -- active_hostiles has settled from 7 to 2 (the two goblin
thieves) with no change to in-game date. Verified this is a genuine,
reproducible fixture-state fact, not per-boot nondeterminism: three
fresh vanilla containers built from the same image produced
byte-identical threats output, and re-running against a container
built from a clean, isolated checkout (no contamination from any other
branch) reproduces the same diff. No other tool's golden changed;
military.json in particular was double-checked to confirm it still
matches the currently-shipped mcp_military.lua exactly.
Per VERIFY.md's own doctrine, a fixture-image bump churning goldens is
expected and should be a reviewable diff -- this is that diff.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes fixture-based golden snapshots to match the current deterministic df-headless:53.15 image.
Changes:
- Removes the absent five-creature threat group.
- Updates hostile totals from seven to two.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/golden/threats.json |
Reflects zero active and two contained hostiles. |
test/golden/fort_status.json |
Updates the hostile alert count to two. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threats/fort_statusgoldens were authored 2026-07-21 against an image whose fixture still had a 5-strong great-danger group ("Monster Of Vomit", DEMON_19) active. The currently-builtdf-headless:53.15fixture no longer has that group —active_hostilessettled from 7 to 2, same in-game date.threatsoutput, and a from-scratch build off a clean, isolated worktree checkout reproduces the identical diff.military.jsonin particular was double-checked to confirm it still matches the currently-shippedmcp_military.luaexactly (ruling out cross-branch contamination noticed mid-investigation).Per
docs/VERIFY.md's own doctrine, a fixture-image bump churning goldens is expected and should land as a reviewable diff — this is that diff.Test plan
npm run typecheck/npm run lintcleanverify:t2passes cleanly against the current fixture image after the update