Skip to content

fix: make OpenShell logo readable in dark mode - #47

Merged
danreed-rh merged 1 commit into
ai-openshell:mainfrom
Taj010:fix-logotext-dark-mode
Aug 18, 2026
Merged

danreed-rh merged 1 commit into
ai-openshell:mainfrom
Taj010:fix-logotext-dark-mode

Conversation

@Taj010

@Taj010 Taj010 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a dark-mode variant of the OpenShell logo (openshell-logo-dark.svg) with white text (#FFFFFF) matching PatternFly 6's --pf-t--global--text--color--regular dark-mode value
  • Swaps the logo src in both the masthead and About modal based on the active theme via useTheme()

Fixes #45

image

Details

The existing logo has hardcoded near-black (#18181A) text glyphs that become invisible on PF6's dark masthead background. Since the logo is rendered as an <img>, CSS cannot reach into the SVG to change fills — so we ship a second SVG asset with white text and select it at runtime.

Only the "OpenShell" text color changes; the green shield (#76B900) and white terminal strokes remain identical in both variants.

Test plan

  • Toggle dark mode — logo text should be white and readable
  • Toggle back to light mode — logo text should be dark as before
  • Open the About modal in dark mode — logo should also use the white-text variant
  • Verify system-preference dark mode (no manual toggle) also picks the correct logo

@Taj010
Taj010 requested a review from Gkrumbach07 as a code owner August 18, 2026 18:37
@danreed-rh danreed-rh self-assigned this Aug 18, 2026
@danreed-rh
danreed-rh merged commit be8d60d into ai-openshell:main Aug 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenShell logo unreadable in dark mode

2 participants