Repository navigation
fix: make OpenShell logo readable in dark mode - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell-logo-dark.svg) with white text (#FFFFFF) matching PatternFly 6's--pf-t--global--text--color--regulardark-mode valuesrcin both the masthead and About modal based on the active theme viauseTheme()Fixes #45
Details
The existing logo has hardcoded near-black (
#18181A) text glyphs that become invisible on PF6's dark masthead background. Since the logo is rendered as an<img>, CSS cannot reach into the SVG to change fills — so we ship a second SVG asset with white text and select it at runtime.Only the "OpenShell" text color changes; the green shield (
#76B900) and white terminal strokes remain identical in both variants.Test plan