Repository navigation
Check plugin data directory assignments - #7
Merged
Merged
Conversation
jonathanhefner
commented
Sep 18, 2026
Compare resolved Core and Recovery data paths to detect storage shared across plugin instances. Check every available Core path so inconsistent assignment within Core cannot hide a collision, and reuse its four observations to check within-plugin consistency. Add only nullable `resolvedData` to the existing Recovery observation. Observed contradictions fail; missing evidence needed to decide remains `not_verified`. Collection needs no additional plugin, tool, or step. Resolve probe root, working directory, and data paths with `realpathSync.native` so Windows junction targets with short and long path spellings remain comparable.
jonathanhefner
force-pushed
the
agent/plugin-data-assignment
branch
from
September 18, 2026 21:58
8df4957 to
19cab71
Compare
jonathanhefner
marked this pull request as ready for review
September 18, 2026 22:01
34 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the observed Core and Recovery plugins receive distinct
PLUGIN_DATApaths. A shared resolved path now failsmcp.stdio.data.distinct-across-plugins. The existing Core observations also supportmcp.stdio.data.consistent-within-plugin, which checks that its four servers share one resolved path.Recovery's existing observation adds only nullable
resolvedData. Collection uses the same three plugins, tools, and guide procedure. Cross-plugin comparison uses all available resolved Core paths; one collision fails, and passing requires usable evidence from both plugins. Core consistency passes when all four paths agree; an observed contradiction fails even if other observations are missing.These checks cover the observed path assignments, not filesystem access restrictions or persistence across updates.
Both probes use native filesystem path resolution so Windows junction targets with short and long path spellings remain comparable.
Validation:
0.155.0-alpha.2.6: eight observations, all 19 cases pass. Core's four data paths agree and Recovery's differs.1.0.83on Node24.18.0: seven observations, 15 pass, two fail, twonot_verified. Core consistency passes; cross-plugin separation remains unverified because the Recovery MCP configuration is rejected. The other unverified case is Recovery server availability; the two failures are the previously observed core argument/environment expansion differences.Both final native runs use unchanged packages from
0929ecb5d7666b9d94f136c66dbfb4c181c68ae1and the ordinary README prompt. Saved observations match the received evidence and both reports match deterministic reevaluation. Codex followed immediate collection/record sequencing. Copilot collected four Core observations together before recording, contrary to the guide; its record writes were sequential and faithful.