Uart shared variant emitter#390
Open
crabel99 wants to merge 46 commits into
Open
Conversation
…in a multi-master configuration
…erving legacy behavior.
…added stopTransmissionWIRE to allow sync closeout, handle errors and continue processing the transaction queue
…g ISR called APIs
…or pin assignment validation
Upstream commit 289a272 added ERROR flag clearing for synchronous blocking I2C operations, but this branch uses ISR-driven async architecture where errors are handled and cleared immediately in interrupt context. The upstream fix doesn't apply to the rewritten async code.
- Fix misleading indentation in retry logic (lines 847, 857) - Remove ambiguous overload for Wire.begin() with integer literals (uint16_t version now requires explicit enableGeneralCall parameter) - Remove unused variable in SPI.cpp - Remove redundant unsigned < 0 check in setPending()
- Add __attribute__((weak)) to all SPI interrupt handlers (SERCOM4, SPI1, etc) This allows variants to override them when SERCOM is used for other peripherals (e.g., MKR variants use SERCOM4 for Serial2/UART) - Explicitly cast slave addresses to uint8_t in Wire examples to avoid any potential overload resolution issues on different compiler versions
…final read." This reverts commit ff93e56.
… final read." This reverts commit 7f91df1.
…ster names to SAME5x names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors UART variant setup so
Uart.cppowns the commonSerial*object and interrupt-handler emission, matching the structure already used by Wire and SPI.Changes
Serial,Serial1throughSerial5, andSerialUART.PERIPH_SERIAL*macro.Uart Serial*object definitions from variant.cppfiles.SERIAL*_IT_HANDLERdefinitions from variant headers where the core can derive them.gemma_m0.Validation
git diff --check -- cores/arduino/Uart.cpp variantspython3 tools/build_all.py metro_m0python3 tools/build_all.py metro_m4python3 tools/build_all.py matrixportal_m4