[codex] Fix DXT generation in deploy workflow#27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe GitHub Actions deploy workflow is updated to include a "Build DXT bundle" step that executes before typecheck, followed by retained typecheck and unit test steps. The deployment phase is modified to call a custom Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
wrangler deploy.Why
The worker imports
src/dxt-bundle.ts, which is generated byscripts/build-dxt.shand intentionally gitignored. A clean GitHub Actions checkout does not have that file, so the Deploy workflow currently fails during typecheck before it can publish the Worker. The generated bundle is also what serveshttps://mcp.absmartly.com/absmartly-mcp.dxt, so it needs to be rebuilt as part of deployment.Validation
./scripts/build-dxt.shnpm run typechecknpm run test:unitgit diff --checkSummary by CodeRabbit