Skip to content

[codex] Fix DXT generation in deploy workflow#27

Draft
Pedro-Revez-Silva wants to merge 1 commit into
absmartly:mainfrom
Pedro-Revez-Silva:codex/fix-deploy-dxt
Draft

[codex] Fix DXT generation in deploy workflow#27
Pedro-Revez-Silva wants to merge 1 commit into
absmartly:mainfrom
Pedro-Revez-Silva:codex/fix-deploy-dxt

Conversation

@Pedro-Revez-Silva

@Pedro-Revez-Silva Pedro-Revez-Silva commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Build the DXT bundle during the Deploy workflow before typecheck.
  • Deploy with the existing DXT verification script instead of raw wrangler deploy.

Why

The worker imports src/dxt-bundle.ts, which is generated by scripts/build-dxt.sh and intentionally gitignored. A clean GitHub Actions checkout does not have that file, so the Deploy workflow currently fails during typecheck before it can publish the Worker. The generated bundle is also what serves https://mcp.absmartly.com/absmartly-mcp.dxt, so it needs to be rebuilt as part of deployment.

Validation

  • ./scripts/build-dxt.sh
  • npm run typecheck
  • npm run test:unit
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Updated deployment pipeline to include a build step and verification process. The CI/CD workflow now performs type checking and unit tests before deploying, ensuring improved deployment reliability.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86fa78ce-841b-40ea-af54-479dd3db6cc5

📥 Commits

Reviewing files that changed from the base of the PR and between 8cf5337 and a85a5bf.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

Walkthrough

The GitHub Actions deploy workflow is updated to include a "Build DXT bundle" step that executes before typecheck, followed by retained typecheck and unit test steps. The deployment phase is modified to call a custom ./scripts/deploy-with-verify.sh script instead of invoking npx wrangler deploy directly. The change alters the workflow order and introduces a verification layer to the deployment process.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • absmartly/mcp#25: Both PRs address TypeScript failures related to the DXT bundle by ensuring the artifact exists before typecheck—this PR uses a dedicated build step, whilst the other uses an ensure-dxt-bundle.sh stub.

Poem

🐇 A bundle builds before the checks now start,
No wrangler waves without a careful heart,
Verify before we fly away so high,
Steps flow like carrots—build, test, then deploy! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing DXT generation in the deploy workflow by adding a build step and updating the deployment process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant