Skip to content

Angular - remove logs from memory token storage service #24497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumeyyeKurtulus merged 1 commit into from
Dec 29, 2025
Merged

Angular - remove logs from memory token storage service #24497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions npm/ng-packs/packages/oauth/src/lib/services/memory-token-storage.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,9 @@ export class MemoryTokenStorageService implements OAuthStorage {
}

private initializeStorage(): void {
console.log('Initialize Storage -->>', typeof SharedWorker !== 'undefined');
// @ts-ignore
if (typeof SharedWorker !== 'undefined') {
try {
console.log('Shared worker is loaded');
console.log('refresh view');
// Create worker from data URL to avoid path resolution issues in consuming apps
// Data URLs are deterministic - same content produces same URL across all tabs
if (!MemoryTokenStorageService.workerUrl) {
Expand All @@ -51,7 +48,6 @@ export class MemoryTokenStorageService implements OAuthStorage {
this.worker = new SharedWorker(MemoryTokenStorageService.workerUrl, {
name: 'oauth-token-storage',
});
console.log('loaded worker -->>', this.worker);
this.port = this.worker.port;
this.port.start();
this.useSharedWorker = true;
Expand Down Expand Up @@ -85,7 +81,6 @@ export class MemoryTokenStorageService implements OAuthStorage {
this.port?.postMessage({ action: 'get', key });
});
} catch (error) {
console.log(error);
this.useSharedWorker = false;
}
} else {
Expand Down Expand Up @@ -140,7 +135,7 @@ export class MemoryTokenStorageService implements OAuthStorage {
try {
this.port.postMessage({ action: 'disconnect' });
} catch (error) {
console.log('Error disconnecting port:', error);
//
}
}
}
Expand Down Expand Up @@ -181,28 +176,22 @@ function broadcastToOtherPorts(senderPort, message) {
try {
p.postMessage(message);
} catch (error) {
console.log('Dead port detected during broadcast, removing...');
deadPorts.push(p);
}
}
});
deadPorts.forEach(p => ports.delete(p));
if (deadPorts.length > 0) {
console.log('Cleaned up', deadPorts.length, 'dead ports. Total ports:', ports.size);
}
}

function removePort(port) {
if (ports.has(port)) {
ports.delete(port);
console.log('Port disconnected. Total ports:', ports.size);
}
}

self.onconnect = (event) => {
const port = event.ports[0];
ports.add(port);
console.log('Port connected. Total ports:', ports.size);

port.addEventListener('messageerror', () => {
removePort(port);
Expand Down Expand Up @@ -239,12 +228,11 @@ self.onconnect = (event) => {
break;

case 'disconnect':
console.log('Port requested disconnect');
removePort(port);
break;

default:
console.warn('Unknown action:', action);
//
}
};

Expand Down
Loading