Repository navigation
Teach card: show the swipe chevrons only while dragging, so they stop flickering - #887
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
The Center under a one-sided Positioned filled the width and set the chevron mid-card, so a tap in the middle of the card hit it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
3 of 5 tasks
…izer starts A lone drag recognizer wins the arena on pointer down and calls onHorizontalDragStart on a plain tap, so a tap on bare card showed them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvtjpBXcvYzPeQPqtMsXwA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The teach card's swipe chevrons appeared 0.1 s after any touch (a tap on the speaker, a scroll, a stray touch) and hid 0.3 s after release, so each short touch fired a fade-in, wiggle and fade-out: a flicker. Owner, 2026-10-29: yes to this change. They now appear, with the wiggle, only when a horizontal drag starts, stay while dragging, and clear 1 s after the drag ends or is cancelled. A tap, a vertical scroll or the speaker button does not show them. A tap on a hidden chevron still moves the card and shows them for the same second, without a second wiggle.
What I verified
Nothing run locally (CI runs analyze, format and tests).
test/teach_swipe_test.dartis new: a tap leaves the chevrons clear, a drag shows them, they clear 1 s after release. Not verified: that test's drag and timing assertions, and thedart formatlayout of the re-indentedbuild.Checklist
flutter analyzeandflutter testpass: left to CIdart format lib testapplied: left to CICo-Authored-By:trailerGenerated by Claude Code