Optimize eager loads - #1473
Merged
Merged
Conversation
Collaborator
|
The thing is, maps are slower for a smaller set. The ideal way would be to decide map vs loop based on the size of the result set |
Collaborator
|
Also, it would be nice to include a micro benchmark so we can judge the tradeoff |
Contributor
Author
This was referenced Jun 18, 2026
mguentner
added a commit
to mguentner/sqlboiler_many_to_many_bug
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, eager loading of relationships uses nested loops, which results in O(n^2) behavior.
For large datasets, this can significantly hurt performance.
I replaced the nested-loop matching with map-based lookups.
After the results are bound, a lookup map is populated from the relevant relationship key values.
Primitive values are normalized with
fmt.Sprintf, while nullable values, especiallynull.XXXstructs, are converted through thedatabase/sql/driver.Valuerinterface.This ensures that nullable foreign key fields are matched correctly while preserving the existing eager-loading behavior.
Please let my know if anything is missing!