Skip to content

feat(checks): add post_test_commands hook to TS and Rust checks - #130

Merged
jleni merged 1 commit into
mainfrom
feat/post-test-commands
Aug 26, 2026
Merged

feat(checks): add post_test_commands hook to TS and Rust checks#130
jleni merged 1 commit into
mainfrom
feat/post-test-commands

Conversation

@jleni

@jleni jleni commented Aug 26, 2026

Copy link
Copy Markdown
Member

Value

  • Secondary build targets stop paying for their own CI job — repos can fold extra builds (storybook production bundles, host-free runtime bundles, variant clippy passes) into the existing checks job's checkout/toolchain/kache instead of repeating container + app-token submodule checkout + mise + package-manager install per target
  • Fully backward compatible — optional input, default empty; existing callers are untouched and need no changes

Technical

  • .github/workflows/_checks-ts.yaml + .github/workflows/_checks-rs.yaml: new optional post_test_commands string input
  • Executed as the last step of the checks job behind if: inputs.post_test_commands != '', so it runs only after format/lint/typecheck/tests/integration/coverage gates all pass; a failing post step fails the job normally
  • Consistent with existing _command inputs: raw shell via direct ${{ }} interpolation, shell: bash

Optional raw-shell input executed as the last step of the checks job,
only after all format/lint/typecheck/test/coverage gates pass. Lets
callers fold secondary build targets into the existing checkout and
toolchain instead of paying a separate job's setup.
@jleni
jleni marked this pull request as ready for review August 26, 2026 09:44
@jleni
jleni merged commit 831302b into main Aug 26, 2026
1 check passed
@jleni
jleni deleted the feat/post-test-commands branch August 26, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant