Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some algorithms were missing from
CoseKey.supported_algorithms(): ESP256-512, Ed25519/448 and RS1 (also ARKG-P256, but it is not suitable as a FIDO2 credential algorithm). This change ensures that allCoseKeyclasses are listed as supported (unless tagged with_UNSUITABLE_AS_FIDO2_CREDENTIAL_ALGORITHM), while maintaining the current explicit list of algorithms as the preference order.Since
Fido2Server.allowed_algorithmsis set fromCoseKey.supported_algorithms()by default, and the class provides no explicit option to configure it, this is needed in order for those missing algorithms to be available when usingFido2Server.register_beginto generate request parameters.