fix: wake render thread directly to stop FPS drop during touch input#538
Open
maxjivi05 wants to merge 2 commits into
Open
fix: wake render thread directly to stop FPS drop during touch input#538maxjivi05 wants to merge 2 commits into
maxjivi05 wants to merge 2 commits into
Conversation
requestRenderCoalesced() routed every game-frame compositor wakeup through the UI thread (mainHandler.post -> Choreographer.postFrameCallback). During touchscreen interaction the UI thread is saturated dispatching MotionEvents, so these wakeups fired late and the coalescing latch collapsed multiple guest presents into one, dropping displayed FPS. Wake the VkRenderer thread directly via xServerView.requestRender(). The render loop still coalesces (one draw per iteration) and native FIFO present still paces to vsync, so the UI-thread/Choreographer hop was redundant as well as harmful. Removes the now-unused mainHandler/renderRequested fields and Handler/Choreographer imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestRenderCoalesced() routed every game-frame compositor wakeup through the UI thread (mainHandler.post -> Choreographer.postFrameCallback). During touchscreen interaction the UI thread is saturated dispatching MotionEvents, so these wakeups fired late and the coalescing latch collapsed multiple guest presents into one, dropping displayed FPS.
Wake the VkRenderer thread directly via xServerView.requestRender(). The render loop still coalesces (one draw per iteration) and native FIFO present still paces to vsync, so the UI-thread/Choreographer hop was redundant as well as harmful. Removes the now-unused mainHandler/renderRequested fields and Handler/Choreographer imports.