Dynamodb insertions core actions and executor - #1728
Open
aschenzle wants to merge 6 commits into
Open
Conversation
Collaborator
|
@aschenzle I think this PR should be made against pr/dynanmodb-insertions-dtos-dsl instead of |
aschenzle
force-pushed
the
pr/dynamodb-insertions-core-actions-executor
branch
from
September 5, 2026 05:28
40b1e6c to
98b7ac4
Compare
aschenzle
changed the base branch from
master
to
pr/dynanmodb-insertions-dtos-dsl
September 5, 2026 05:35
arcuri82
force-pushed
the
pr/dynamodb-insertions-core-actions-executor
branch
from
September 8, 2026 11:57
98b7ac4 to
2d03835
Compare
jgaleotti
approved these changes
Sep 8, 2026
| Object builder = attributeValueClass.getMethod("builder").invoke(null); | ||
| String setter; | ||
| Object value; | ||
| switch (attribute.type) { |
Collaborator
There was a problem hiding this comment.
why not having the same d action for all printable values?
Collaborator
Author
There was a problem hiding this comment.
Maybe there's a confusion. Here we determine which method to call by reflection in line 115. We need to use the exact method name (s,n,bool).
aschenzle
force-pushed
the
pr/dynamodb-insertions-core-actions-executor
branch
from
September 8, 2026 23:47
2d03835 to
4bfdbe5
Compare
aschenzle
changed the title
…ons-executor' into pr/dynamodb-insertions-core-actions-executor
jgaleotti
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin classes for DDB insertions including Action, executor, builder