Repository navigation
ci: make the Secure Boot test blocking again - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
continue-on-erroradded in #85, now that #86 gives GRUB an SBAT section and built-in modules (#84).Please let this run finish before merging. #86 merged before its VM tests completed, so nothing has run the Secure Boot test against the GRUB change yet. The ordinary VM tests boot the kernel directly rather than through GRUB, so they don't cover it. This PR's
vm-testsrun is the first real check of #86:SecureBoot=1, and the unsigned kernel was refused. Secure Boot: shim rejects our GRUB because it has no .sbat section #84 is really fixed.continue-on-errorback and reopen Secure Boot: shim rejects our GRUB because it has no .sbat section #84.🤖 Generated with Claude Code