Repository navigation
feat(account): change the master password with device verification (#629) - #641
Merged
Merged
Conversation
A password changed on another device revokes this device's refresh token but its access token stays valid for up to an hour, so the device option read the stored, now stale password and the server answered "current password incorrect". Refreshing first catches the revocation before any system prompt and points the user to sign in again.
kipavy
force-pushed
the
feat/password-change-device-auth-629
branch
from
October 14, 2026 19:15
955c1c0 to
ebf411c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629.
On a signed-in device, the Change master password dialog now offers "Forgot it? Confirm with {method} instead" under the current-password field. The method is Windows Hello, Touch ID or your Mac password, your system password, or your fingerprint or screen lock.
The device already keeps the master password in the OS keychain. After the OS confirms the user, that stored password stands in for the typed one:
system_auth_verifyfirst.The server still checks the old auth key and the second factor.
Behaviour
system_auth_available) or the secret is sealed. Without one, an unlocked device alone is not enough to take over the account, so the typed path is the only option.readPasswordWithSystemAuthis shared withunlockWithSystemAuth, which now uses it.Depends on
#640 (merged), which fixes the identity and stranded-vault bugs a password change used to cause on linked accounts.
Tests
ChangeMasterPasswordModal.test.tsx(6 cases):vaultBinding.test.tscovers plain with verify, declined, sealed, and nothing stored.Screenshots
Captured from a real build against a local test server. Shared with the maintainer separately (private artifact):