Repository navigation
fix(catalogue): icons for System Metrics and Process Manager - #34
Merged
Merged
Conversation
Browse renders the catalogue entry's icon, not the bundled manifest's. voltius#310 added icons to both manifests, but these two entries never carried one, so Browse still showed the puzzle fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse reads
iconfrom the catalogue entry only. VoltiusApp/voltius#310 setlucide:activity/lucide:cpuin the bundled manifests, but these two catalogue entries never had anicon, so Browse fell back to the puzzle. Values match the manifests.stamp-hashes.mjs --checkpasses and a stamp run produces no extra diff.