Repository navigation
Only store the NBLAST link cookie when the user agrees - #1803
Merged
Merged
Conversation
The upload dialog asks for consent to keep the query link in a cookie, but set it whether or not the box was ticked. It now sets it only when ticked, and the Learn More link points at VFB's own cookies page, which lists it, rather than Wikipedia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload dialog asks for consent to keep the NBLAST query link in a cookie, but set the cookie whether or not the box was ticked. It now sets it only when ticked; the link is still shown to copy either way. The "Learn More" link now points at VFB's own cookies page (
/about/cookies/#functional-cookies), which lists the cookie, instead of Wikipedia. Follow-up to #1802.