Repository navigation
Unpin bottleneck so CI installs a NumPy-2-compatible build - #289
Merged
Merged
Conversation
requirements.txt pinned bottleneck<=1.3.6 (compiled against NumPy 1.x) while CI installs numpy>=2.0; importing it under NumPy 2 raises 'AttributeError: _ARRAY_API not found' inside pandas/xarray, which has been failing the Data Access, OWL Reasoning and Visualization live test suites on every recent run. bottleneck>=1.4 ships NumPy-2-built wheels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three live test suites (Data Access & Query, OWL Reasoning, Visualization & Image) have been failing on every recent run — including on master before #288 and on the v2.4.3 tag build — with
AttributeError: _ARRAY_API not found.Cause:
requirements.txtpinsbottleneck<=1.3.6(a 2022 wheel compiled against NumPy 1.x) while.github/workflows/requirements.txtpinsnumpy>=2.0. pandas and xarray import bottleneck as an optional accelerator, and a NumPy-1-built extension under NumPy 2.2.6 raises_ARRAY_API not foundat import, killing test collection. Full trace in any failing job (e.g. pandasnanops.py→import bottleneck).Fix: relax the pin to
bottleneck>=1.4.2— the 1.4+ line ships NumPy-2-built wheels (cp310 included; verifiedbottleneck1.6.0 imports cleanly alongside NumPy 2.x).Not included (PAT can't touch
.github/workflows/):.github/workflows/requirements.txtstill listsjsonpath_rw, a leftover from #288 that makes CI build the fragile legacy sdist for nothing — worth deleting that one line while you're in there.