Repository navigation
nfa: +fix Build the product map in naive inclusion only for a counterexample - #874
Merged
Merged
Conversation
Adda0
marked this pull request as ready for review
October 8, 2026 12:57
…example `is_included_naive()` always passed `&prod_map` to `intersection()`, but it only reads the map to translate the counterexample path back to `smaller`'s states. Without a counterexample the map is filled and thrown away. Measured on a 600 000-state / 3 591 612-transition product (Release `-O3 -DNDEBUG`, GCC 16.2, pinned to one core, 3 runs): `intersection()` takes 536-574 ms with the map and 218-297 ms without it. Part of #750. Part of #726.
Adda0
force-pushed
the
issue-750-incl-prodmap-pr
branch
from
October 8, 2026 12:58
0351789 to
2e512cb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_included_naive()always passed&prod_maptointersection(), but itonly reads the map to translate the counterexample path back to
smaller'sstates. Without a counterexample the map is filled and thrown away.
Measured on a 600 000-state / 3 591 612-transition product (Release
-O3 -DNDEBUG, GCC 16.2, pinned to one core, 3 runs):intersection()takes536-574 ms with the map and 218-297 ms without it.
Part of #750.
Part of #726.