Skip to content

Prevent updater downloads from hanging indefinitely #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+2 −1
Closed

Prevent updater downloads from hanging indefinitely #1477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583efb9
Initial plan
Copilot Sep 12, 2026
ca9219d
Bound updater download reads
Copilot Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion HandheldCompanion/Managers/UpdateManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public enum UpdateStatus
private static string updateUrl = string.Empty;
private static readonly HttpClient httpClient;
private static readonly string InstallPath;
private static readonly TimeSpan DownloadReadTimeout = TimeSpan.FromSeconds(30);

private static Timer autoTimer = new(TimeSpan.FromMinutes(10)) { AutoReset = true };

Expand Down Expand Up @@ -280,7 +281,7 @@ public static async Task DownloadUpdateFile(UpdateFile update)
var buffer = new byte[81920];
long bytesReadSoFar = 0;
int read;
while ((read = await sourceStream.ReadAsync(buffer, 0, buffer.Length)) > 0)
while ((read = await sourceStream.ReadAsync(buffer, 0, buffer.Length).WaitAsync(DownloadReadTimeout)) > 0)
{
await destStream.WriteAsync(buffer, 0, read);
bytesReadSoFar += read;
Expand Down