Repository navigation
catalogs: freeze e-file table metadata per release - #109
Merged
Merged
Conversation
Catalog pages read form, part, title, cardinality and sort order from efile/TABLE-META-<id>.csv, frozen from the concordance990 ref each release was labelled with (EFILE_RELEASES$concordance_ref), instead of whatever concordance990 is installed at render time. Archive pages keep their own labels. v1-labelled releases take titles from concordance990 2.0.0, since the frozen v1 concordance has none. Adds efile/make-efile-table-meta.R, efile_release_meta(), tests, and re-renders the five pages that used efile_concordance(). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
read.csv turned an entirely blank title column into NA, and the page then printed a title paragraph reading NA for every table (111 on the v2_2 page, 81 on pf_v2_3, 80 on pf_v3_1). Read the text columns as character, blank any NA, add a regression test, re-render the three pages. Review finding from Codex on PR #109. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog pages for the e-file releases read form, part, title, cardinality and sort order from a per-release frozen file (
catalogs/efile/TABLE-META-<id>.csv) instead of the concordance990 version installed at render time. Each release's file is generated bycatalogs/efile/make-efile-table-meta.Rfrom the concordance990 git ref the release was labelled with, recorded inEFILE_RELEASES$concordance_ref. Archive pages therefore keep their own labels after concordance990 moves on.Notes for review:
v2.0.0-baseline) has no form, part or table titles. Releases labelled with v1 (v2_2) take table membership, cardinality and order from the baseline and fill titles from concordance990 2.0.0. Without that the v2_2 page lost every part heading.efile_release_meta()stops with the missing table names when a count file gains a table that the frozen file lacks; rerun the script for that release.Rscript catalogs/tests/test-efile-helpers.R, 10 passing.Part of the efile_v3_1 review (nccs-contracts #108, release note in nccs-contracts). ADR 0022 breadcrumb: catalog surface change, no contract shape change.
🤖 Generated with Claude Code