FIX: Renamed window from 'Input Debug' to Input Debugger (UUM-137124)#2435
FIX: Renamed window from 'Input Debug' to Input Debugger (UUM-137124)#2435alexandrarussell wants to merge 4 commits into
Conversation
|
|
alexandrarussell
changed the title
alexandrarussell
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
A straightforward rename of the Input Debugger window; however, a small edge case in how Unity restores window layouts might prevent the new title from appearing in existing workspaces.
Additional observations
-
Packages/com.unity.inputsystem/InputSystem/Editor/Debugger/InputDebuggerWindow.cs:53(medium) — BecausetitleContentis only assigned whens_Instance == null, this updated title won't be applied for users who already have the window saved in their Unity Editor layout.When Unity restores the window from a saved layout, it will use the previously serialized name ("Input Debug"). If the user then clicks the menu item to focus the window,
s_Instancewill already be non-null (as restored by Unity), so execution will fall into theelseblock and the title will never update to "Input Debugger".To ensure the new name is applied even when restoring from layouts, consider setting it unconditionally outside the
if (s_Instance == null)check, or moving thetitleContentassignment into anOnEnable()method.
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2435 +/- ##
============================================
+ Coverage 58.58% 79.03% +20.45%
============================================
Files 738 765 +27
Lines 135831 140375 +4544
============================================
+ Hits 79570 110943 +31373
+ Misses 56261 29432 -26829 Flags with carried forward coverage won't be shown. Click here to find out more.
|
ritamerkl
left a comment
ritamerkl
left a comment
There was a problem hiding this comment.
One nitpick.
Thanks for taking care of this!
2 participants
Description
The input debugger window was originally named 'Input Debug'. This PR changes it to 'Input Debugger'.
Testing status & QA
I have tested for the desired outcome (window is named correctly) on Windows and Mac.
I ran local tests from the Test Runner on Windows.
Overall Product Risks
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.