test(data-fabric): stall-harden the entity-methods block - #731
Closed
Sarath1018 wants to merge 1 commit into
Closed
Sarath1018 wants to merge 1 commit into
Sarath1018 wants to merge 1 commit into
Conversation
…he entity-methods block The Entity-level methods block re-fetched the entity via getById inside every test, so each write test's 30s budget covered two round-trips — doubling its exposure to alpha's gateway stalls — and its write tests were left at the default 30s when the suite's other DF write paths were sized to 90s. Fetch the entity once in beforeAll (still exercising the getById→bound-methods path) and give the four write tests 90s budgets; reads keep the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
Author
|
Consolidated into #726 (commit cherry-picked onto sarath/fix-lost-resume-race) so the DF and maestro stall-hardening land together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Entity-level methods (via getById)block is the recurring victim of alpha's gateway stalls:updateRecordsanddeleteRecordsdied at exactly ~30s on consecutive CI attempts. Two flow defects:entities.getById()inside its own timeout budget — each write test had to fit two round-trips (metadata read + batch write) into 30s, doubling its exposure to a single stall window, and violating the repo rule that shared lookups belong inbeforeAll.Fix
getByIdin abeforeAll(90s), stored inlet entity!: EntityGetResponse— the block still exercises the getById→bound-methods path on a live response object; only the redundant re-fetches are gone.insertRecord,insertRecords,updateRecords,deleteRecords); the two read tests keep the default.Validation
🤖 Generated with Claude Code