-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support federated entities creation in sdk #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ddba050
feat(data-fabric): migrate entities to v3 APIs [DS-8953]
niket0503 8dd9d4a
feat(data-fabric): support federated entity create, update, and query
niket0503 18ceb4f
feat(data-fabric): migrate by-name and choiceset endpoints to v3
niket0503 0028f41
fix(data-fabric): integration test fixes + review-comment follow-ups
niket0503 6079a13
test(data-fabric): pass displayName on the isAnalyticsEnabled metadat…
niket0503 2d853de
docs(data-fabric): mark ExternalSourceFields.nativeConnectionDetail @…
niket0503 9d24883
refactor(data-fabric): share idsEqual helper + drop @experimental on …
niket0503 23aacb2
refactor(data-fabric): use a single v3 by-name query endpoint
niket0503 a39afc3
fix(data-fabric): set analytics only at create, drop it from updateById
niket0503 96f69b3
docs(data-fabric): mark Searchability* interfaces @experimental
niket0503 6aa74a8
fix(data-fabric): keep DataDirectionType as a string enum
niket0503 2c6228e
test(data-fabric): use strict Id equality; drop idsEqual casing worka…
niket0503 0968152
docs(data-fabric): fix bound update() @param + elementInstanceId exam…
niket0503 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per conventions,
@exampleblocks must be self-contained and copy-pasteable — every named type they reference needs to appear in the import statement. The import at the top of this block (earlier in the same```typescriptfence) is:This PR introduces
EntityClass(here) andDataDirectionType(used a few lines below) without adding them to that import.EntityFieldDataTypewas also already missing pre-PR. The import should become:The same issue applies to the
updateByIdexample block, which usesDataDirectionType.ReadOnlyandJoinType.LeftJoinin the new Federated examples but has no import statement at all in that block.