fix(docs): HITL outcome ports were documented as a single completed handle - #3259
dushyant-uipath wants to merge 1 commit into
Conversation
QuickForm HITL nodes wire one outcome-<outcome.id> port per outcome, not a single completed handle. The old docs taught completed unconditionally across both skills, so agents following them left every non-default outcome dangling. Corrected 8 uipath-maestro-flow references, the sibling uipath-human-in-the-loop skill (SKILL.md, hitl-node-quickform.md, hitl-node-apptask.md), and a coded-action-app example that had wrongly flipped onto outcome-derived ports by gaining an inputs.schema block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Claude finished @dushyant-uipath's task in 2m 53s —— View job PR Review: fix(docs): HITL outcome ports were documented as a single completed handle
SummaryCorrects the HITL QuickForm port wording across both Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not touched; no issues |
| E2E Tests | OK | Docs-only change; no new CLI workflows or commands introduced |
| Skill Body | OK | Critical Rules updated correctly in both skills |
| References & Assets | OK | All 8 maestro-flow references + 2 HITL references updated consistently; all relative links verified; anchor references resolve |
| Repo Hygiene | OK | No secrets, no new skills, no cross-skill structural deps (existing doc-context links are pre-existing and properly marked) |
Issues for Manual Review
- Domain accuracy: The per-outcome port semantics (
outcome-<outcome.id>vs. staticcompletedfor app-based nodes) are a domain-specific claim about the Maestro Flow runtime. A reviewer with platform knowledge should confirm these semantics match the actual runtime behavior. outcome-completededge case: The docs now state thatoutcome-completedis both the zero-outcome placeholder AND a valid port when an outcome'sidis literallycompleted. This dual role is clearly documented but could still confuse agents — worth a domain expert sanity check.
Conclusion
Clean, well-scoped docs-only PR. All 11 files are internally consistent, all links resolve, and the old completed wording has been comprehensively replaced with per-outcome port semantics. The only nitpick is a missing trailing newline in impl.md (pre-existing, Low severity). Approve.
|
|
Closing. Reconsolidated back into #3180 as a single PR. |
Problem
QuickForm HITL nodes wire one
outcome-<outcome.id>port per outcome. The docs taught a singlecompletedhandle regardless of outcome count, so an agent following them left every non-default outcome unwired.Fixed
completedunconditionally: corrected to per-outcomeoutcome-<id>ports.inputs.schemablock it shouldn't have had: the block is removed, port stays the staticcompletedfor that node type.outcome-completednever reappears once outcomes exist: corrected. It is the zero-outcome placeholder, or the port for a real outcome whose ownidhappens to becompleted.Docs only, no executable surface changed.
Split from #3180
Split out of #3180 into three, so documentation wording, checker logic, and task fixtures each get their own reviewable diff: docs here, checker logic in #3260, task fixture migration in #3261 (depends on #3260). #3180 is closed in favor of these three.
🤖 Generated with Claude Code