Remove name based filter for maestro flow - #3197
Draft
Mihaiii wants to merge 2 commits into
Draft
Conversation
Mihaiii
changed the title
…prune dot-dirs Run 2026-09-10_11-06-05 (studio-web) still zeroed 21 tasks on `No .flow file matching '<Name>*.flow'`: dropping --flow-name from the YAMLs left the same anchor in ~25 per-task check_*.py graders (find_flow_file(flow_glob=...), FLOW_GLOB, advisory load_flow), while Studio Web keeps the scaffolded `new.flow` and the harness exports it verbatim. - flow_check.find_flow_files: flow_glob selects among a project's flows; when it matches nothing the project's own .flow files are used and find_flow_file still refuses a genuinely ambiguous set. - flow_check._rglob_pruned: skip dot-directories. eval-local-crud kept two failed `flow init` attempts in hidden scratch dirs beside the real 1-node build and the checker refused all three as equal candidates. - advisory_flow_utils.load_flow: fall back to a lone generated .flow. - check_drive_to_slack: route through the shared find_flow_file. - 8 discovery tests for the new behaviour. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Will get back to this after #3124 is merged into main (after the review process) and main into this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://uipath.atlassian.net/browse/PILOT-7533
Studioweb outputs "new.flow" flow files instead of "<proj_name>.flow" file names, which are expected in tests. Therefore, studioweb stdio test checks fail even though the flow was generated. This is a test issue - the name doesn’t have to be in a particular format.
Run example (maestro-flow only) here with (unmerged) studioweb stdio and this skills branch:
https://dev.azure.com/uipath/coder_eval/_build/results?buildId=13343309&view=resultsResults: TODO
Run example (maestro-flow only) here with Delegate SDK and this skills branch:
https://dev.azure.com/uipath/coder_eval/_build/results?buildId=13339361&view=resultsResults: TODO