Skip to content

fix(test): raise e2e_01 task_timeout to 2400s - #1981

Closed
dushyant-uipath wants to merge 1 commit into
mainfrom
fix/hitl-e2e01-task-timeout
Closed

dushyant-uipath wants to merge 1 commit into
mainfrom
fix/hitl-e2e01-task-timeout

Conversation

@dushyant-uipath

Copy link
Copy Markdown
Collaborator

e2e_01 mentions SharePoint and SAP in the prompt. The agent does real connector registry lookups for both, which burns most of the 1200s nightly default before the HITL node is ever placed. The flow produced has no HITL node and no edges — score 0.0, timeout.

Root cause: turn_timeout: 2400 was already set (per-turn) but task_timeout was missing, so the 1200s nightly default applied to the whole task.

Fix: add task_timeout: 2400 to match the per-turn limit.

🤖 Generated with Claude Code

The nightly default is 1200s total. e2e_01 prompts for SharePoint and
SAP which triggers real connector registry lookups — these eat the clock
before the HITL node is ever added. 2400s matches the existing per-turn
limit and gives the agent enough headroom.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @dushyant-uipath's task in 48s —— View job


PR Review: fix(test): raise e2e_01 task_timeout to 2400s

  • Gather context — read review criteria, diff, and full changed file
  • Review the change against project conventions
  • Post review findings

Summary

Adds the missing task_timeout: 2400 to the HITL e2e_01 task so the overall task limit matches the already-set per-turn timeout of 2400s. Without this, the 1200s nightly default applied and the task timed out before the agent finished its SharePoint/SAP connector lookups.

Change-by-Change Review

1. tests/tasks/uipath-human-in-the-loop/e2e_01_invoice_approval_greenfield.yaml — line 16

Severity: OK

The addition of task_timeout: 2400 is correct and well-placed within the run_limits block, directly above turn_timeout: 2400. The two values are consistent — a task-level timeout equal to the per-turn timeout makes sense for a single-turn-dominant task where most wall-clock time is spent in one long agent turn doing connector lookups. YAML is valid. No other fields were touched.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter N/A No skill frontmatter changed
E2E Tests OK Existing test task updated with correct timeout
Skill Body N/A No skill body changed
References & Assets N/A No references or assets changed
Repo Hygiene OK Scoped single-line fix, no secrets or stray changes

Issues for Manual Review

None found.

Conclusion

Clean, minimal, well-motivated fix. The root cause is clearly explained in the PR description and the change directly addresses it. Approve.

@github-actions

github-actions Bot commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @dushyant-uipath's task in 1m 47s —— View job


Coder-eval task lint (advisory)

1 task YAML changed; verdict counts: 0 Critical, 0 High, 1 Medium, 0 Low, 0 OK.

Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge.

Evidence of passing run

❌ High — PR body does not claim the modified task has been re-run and still passes with the new task_timeout. Please edit the PR description to add a line like:

Ran skill-hitl-e2e-invoice-approval-greenfield locally and it passed.

Per-task lint

tests/tasks/uipath-human-in-the-loop/e2e_01_invoice_approval_greenfield.yaml — verdict: Medium

Issues:

  • [Medium] Near-duplicate: substantial overlap with e2e_06_invoice_approval_greenfield_simple.yaml — both are green-field invoice approval flows named "InvoiceApproval" with the same HITL node type check, completed-handle check, and flow validate criterion. e2e_01 adds SharePoint/SAP connector discovery and $vars output-binding regex (lines 65-67); e2e_06 adds solution init + flow init scaffolding checks. Each adds marginal coverage but the core operation is the same.

Suggested fixes:

  • Consider whether the connector-discovery coverage in e2e_01 justifies a separate task or could be folded into e2e_06 with an expanded prompt. If both are kept, document the distinction in the description field of each (e.g. "exercises connector registry lookup" vs "exercises project scaffolding").

Within-PR duplicates

  • No duplicate clusters detected (only 1 file changed).

Conclusion

  • ⚠ 1 task has issues, max severity Medium. Advisory only — not blocking merge. Evidence of passing run is missing from PR body (High, but not a task-design issue).

@dushyant-uipath

Copy link
Copy Markdown
Collaborator Author

Closing: superseded. e2e_01's timeout and scenario were rewritten multiple times since (#3196, #3180); current state is task_timeout/turn_timeout 1200/1200 with a scaled-down, mocked scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant