fix(maestro-flow-skill): remove stale v1.6 node type from HITL plugin docs - #1878
dushyant-uipath wants to merge 6 commits into
Conversation
|
Claude finished @dushyant-uipath's task in 1m 44s —— View job PR Review: fix(maestro-flow-skill): remove stale v1.6 node type from HITL plugin docs
SummaryMigrates the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No frontmatter changes |
| E2E Tests | OK | PR description confirms this fixes existing test failures (skill-flow-hitl-smoke-node-placed, etc.) — no test changes needed |
| Skill Body | OK | No SKILL.md changes |
| References & Assets | Medium | JSON blocks correct; surrounding prose for Option 2 header/description is stale |
| Repo Hygiene | OK | Scoped changes, no secrets, no cross-skill deps introduced |
Issues for Manual Review
- Verify that the three referenced test tasks (
skill-flow-hitl-smoke-node-placed,skill-flow-hitl-quality-brownfield-insert,skill-flow-hitl-quality-result-downstream) now pass with these doc changes.
Conclusion
The core fix (JSON node types and CLI output) is correct and well-scoped. One Medium issue: the Option 2 section header and description in impl.md still reference the removed inputs.type field and incorrectly claim the same node type as Option 1. Recommend fixing those two lines before merging to avoid misleading agents.
… docs Same issue as #1847 but in the maestro-flow skill's HITL plugin. The impl.md quick-reference JSON used "uipath.human-in-the-loop" + "inputs.type": "quick" (v1.6), causing skill-flow-hitl-* tests to fail the node type check. - hitl/impl.md: QuickForm node type → uipath.human-in-the-loop.quick-form, remove inputs.type - hitl/impl.md: AppTask node type → uipath.human-in-the-loop.coded-action-app, remove inputs.type - cli-commands.md: update NodeType in success output example Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rify AppTask version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ix variable prefix examples Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ance across all reference docs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…efinition block
- quickform definition: fix sortOrder (50→27), label ("Human in the Loop"→"Quick Form"),
add description, add "quick-form" tag, remove stale "label" on completed handle
- apptask: replace "Same definition as QuickForm" pointer with full coded-action-app
definition block (own nodeType, sortOrder 28, own tags/description)
- coded-action-app: update cross-reference to point to apptask definition entry
- quickform script example: use inline $vars access, not destructuring
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f79b569 to
f9b74c8
Compare
Fix stale v1.6 node types in
uipath-maestro-flowHITL plugin docs.hitl/impl.md: QuickForm type →uipath.human-in-the-loop.quick-form, removedinputs.type: "quick"hitl/impl.md: AppTask type →uipath.human-in-the-loop.coded-action-app, removedinputs.type: "custom"cli-commands.md: updateNodeTypein thehitl addsuccess output exampleCloses #
🤖 Generated with Claude Code