Skip to content

fix(maestro-flow-skill): remove stale v1.6 node type from HITL plugin docs - #1878

Closed
dushyant-uipath wants to merge 6 commits into
mainfrom
fix/maestro-flow-hitl-node-types
Closed

dushyant-uipath wants to merge 6 commits into
mainfrom
fix/maestro-flow-hitl-node-types

Conversation

@dushyant-uipath

@dushyant-uipath dushyant-uipath commented Jul 6, 2026 •

Copy link
Copy Markdown
Collaborator

Fix stale v1.6 node types in uipath-maestro-flow HITL plugin docs.

  • hitl/impl.md: QuickForm type → uipath.human-in-the-loop.quick-form, removed inputs.type: "quick"
  • hitl/impl.md: AppTask type → uipath.human-in-the-loop.coded-action-app, removed inputs.type: "custom"
  • cli-commands.md: update NodeType in the hitl add success output example

Closes #

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @dushyant-uipath's task in 1m 44s —— View job


PR Review: fix(maestro-flow-skill): remove stale v1.6 node type from HITL plugin docs

  • Read review criteria and project conventions
  • Read full diff (origin/main...HEAD)
  • Read full changed files for surrounding context
  • Verify relative links resolve
  • Check for cross-skill references, secrets, etc.
  • Post review findings

Summary

Migrates the uipath-maestro-flow HITL plugin docs from the stale v1.6 node-type pattern ("type": "uipath.human-in-the-loop" + "inputs.type") to the current subtype-specific pattern (uipath.human-in-the-loop.quick-form / .coded-action-app), matching the fix already applied in uipath-human-in-the-loop via #1847.

Change-by-Change Review

1. skills/uipath-maestro-flow/references/author/references/plugins/hitl/impl.md (+2/−4)

Severity: Medium (one issue in surrounding prose)

The JSON code blocks are correctly updated:

  • Option 1: "type" → "uipath.human-in-the-loop.quick-form", "inputs.type": "quick" removed ✅
  • Option 2: "type" → "uipath.human-in-the-loop.coded-action-app", "inputs.type": "custom" removed ✅

Issue — stale section header and prose on lines 89 and 91:

After this PR, line 89 still reads:

## Option 2 — App-Based HITL (`uipath.human-in-the-loop` with `inputs.type = "custom"`)

and line 91:

Use when there is an existing deployed Action Center app … Same node type as Option 1 — only `inputs.type`, `inputs.app`, and `inputs.appInputBindings` differ.

Both are now incorrect — the JSON no longer has inputs.type, and the node types are now distinct (.quick-form vs .coded-action-app). An agent reading the header would still think inputs.type = "custom" is required, contradicting the updated JSON below it.

Suggested fix for line 89:

## Option 2 — App-Based HITL (`uipath.human-in-the-loop.coded-action-app`)

Suggested fix for line 91 (remove the "Same node type" claim and the inputs.type reference):

Use when there is an existing deployed Action Center app that should serve as the task form. Distinguished from Option 1 by `inputs.app` and `inputs.appInputBindings`.

Fix this →

2. skills/uipath-maestro-flow/references/shared/cli-commands.md (+1/−1)

Severity: OK

NodeType in the hitl add success output example updated from "uipath.human-in-the-loop" to "uipath.human-in-the-loop.quick-form". Correct and consistent with the impl.md changes.

What's Missing

  • Stale prose in impl.md — the section header (line 89) and description (line 91) for Option 2 still reference inputs.type = "custom" and claim "Same node type as Option 1," both of which are now wrong after this fix. See finding above.

Area Ratings

Area Status Notes
Frontmatter OK No frontmatter changes
E2E Tests OK PR description confirms this fixes existing test failures (skill-flow-hitl-smoke-node-placed, etc.) — no test changes needed
Skill Body OK No SKILL.md changes
References & Assets Medium JSON blocks correct; surrounding prose for Option 2 header/description is stale
Repo Hygiene OK Scoped changes, no secrets, no cross-skill deps introduced

Issues for Manual Review

  • Verify that the three referenced test tasks (skill-flow-hitl-smoke-node-placed, skill-flow-hitl-quality-brownfield-insert, skill-flow-hitl-quality-result-downstream) now pass with these doc changes.

Conclusion

The core fix (JSON node types and CLI output) is correct and well-scoped. One Medium issue: the Option 2 section header and description in impl.md still reference the removed inputs.type field and incorrectly claim the same node type as Option 1. Recommend fixing those two lines before merging to avoid misleading agents.


dushyant-uipath and others added 6 commits July 7, 2026 01:43
… docs

Same issue as #1847 but in the maestro-flow skill's HITL plugin. The impl.md
quick-reference JSON used "uipath.human-in-the-loop" + "inputs.type": "quick"
(v1.6), causing skill-flow-hitl-* tests to fail the node type check.

- hitl/impl.md: QuickForm node type → uipath.human-in-the-loop.quick-form, remove inputs.type
- hitl/impl.md: AppTask node type → uipath.human-in-the-loop.coded-action-app, remove inputs.type
- cli-commands.md: update NodeType in success output example

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rify AppTask version

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ix variable prefix examples

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ance across all reference docs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…efinition block

- quickform definition: fix sortOrder (50→27), label ("Human in the Loop"→"Quick Form"),
  add description, add "quick-form" tag, remove stale "label" on completed handle
- apptask: replace "Same definition as QuickForm" pointer with full coded-action-app
  definition block (own nodeType, sortOrder 28, own tags/description)
- coded-action-app: update cross-reference to point to apptask definition entry
- quickform script example: use inline $vars access, not destructuring

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dushyant-uipath

Copy link
Copy Markdown
Collaborator Author

Closing: predates the references/ directory flattening (#2879); the touched path no longer exists. The HITL plugin docs it edits have since been rewritten in #3180/#3267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant