feat(apollo-react): centralized guardrails section and read-only details [AL-578]

[andreizdrali-uipath]

Implements AL-578: the read-only section for the
guardrails an organization's AI Trust Layer governance policy enforces on an agent, and the details
content behind a row. Both products ship this today, each with its own copy and its own component
tree.

What lands

Module	Public surface
centralized-types.ts	CentralizedGuardrail and the five shapes around it
centralized-guardrail-utils.ts	filtering, definition matching, display resolution, resolveCentralizedGuardrailParameters, three label formatters. Pure, React-free
centralized-guardrails-section.tsx	CentralizedGuardrailsSection
centralized-guardrail-details.tsx	CentralizedGuardrailDetails
i18n.ts	CentralizedGuardrailsLabels, CENTRALIZED_GUARDRAILS_EN_LABELS, CENTRALIZED_GUARDRAILS_EN_MESSAGES, resolveCentralizedGuardrailsLabels, useCentralizedGuardrailsLabels

policy.centralizedGuardrails → getApplicableCentralizedGuardrails → CentralizedGuardrailsSection
                                       (host filters)                  onSelect(guardrail)
                                                                              ↓
                                                     host dialog / panel ⊃ CentralizedGuardrailDetails

Plus four private components (row, origin chip, parameters, detail field), a README section,
Components/UiPath/Centralized Guardrails stories including both host shells, and the
guardrails.centralized.* catalog ids.

Decisions worth checking

• A governance record is its own type, not a variant of GuardrailBuilderValue. No id,
  scopes at the top level rather than under a selector, action a bare discriminator.
  centralized-types.ts mirrors both products' zod schemas structurally, so each host passes its
  own inferred type with no mapping: executionStage stays string because both parse it as one,
  and action is the closed four-value union both close it to, which a TypeScript string enum
  member assigns to, so Agents' ActionType fits.
• Props, never contexts. Both products hold the policy and the definitions in a context of
  their own (useAiTrustLayerGovernancePolicy, useGovernance, GuardrailDefinitionsContext), so
  reading one here would tie the component to whichever host it was written in.
• The host filters, the component renders. getApplicableCentralizedGuardrails is the
  agent-kind predicate both products already run, exported so neither rewrites it. An empty list
  renders nothing, which is what both do; emptyState overrides that.
• definitions is optional and undefined means "not loaded yet", which is what keeps a row
  from claiming a configuration was deleted while the catalog is still in flight. An empty array
  means it loaded and the configuration really is gone.
• One configuration resolver for both origins. A BYO guardrail states its configuration as
  connector parameters and a built-in as entities / entityThresholds.
  resolveCentralizedGuardrailParameters lifts the built-in fields onto the parameter shape so one
  path covers both, and it discriminates on each value's own shape rather than on parameterType,
  which is an unvalidated wire string.
• A read-only value is text, not a disabled input. The family's parameter editors are the
  MetadataForm stack and have no read-only mode, and these values arrive as untyped wire data
  rather than as GuardrailValidatorParameters. A disabled input also cannot be focused, so its
  content is not selectable, not copyable and skipped by a screen reader.
• The row's accessible name is its own text, not an aria-label.
• mt-0 on the details' title-less note, the workaround GuardrailStatusBanner already
  carries. Wind's AlertDescription is unconditionally mt-1, which assumes an AlertTitle
  above it, while alertVariants pins the icon at top-3.5, so a title-less alert renders its
  text 4px below its icon. The real fix is one line in alertVariants.

QA-visible changes

Both products

• Entities render through the definition's option labels: "US Social Security Number (SSN)" instead
  of USSocialSecurityNumber, matching the guardrail editor next to it.
• Each validator's configuration is labelled from its own definition ("Content categories" /
  "Severity thresholds" for harmful content, "Detection thresholds" for PII) instead of one generic
  pair, which stays as the fallback when no definition matched.
• A BYO parameter renders by its value's shape, not its parameterType: a scalar tagged
  map-enum shows instead of vanishing, and a threshold map persisted as null leaves its
  entity list as its own labelled row instead of an empty table.
• A BYO entry with no name shows its validator id rather than the built-in's curated name.
• A broken BYO configuration gains GuardrailList's status chip (Unavailable / Disabled)
  next to the name. The remediation sentence both products already show stays underneath: the
  chip is for finding the row, the sentence for fixing it.
• The row's accessible name becomes its own text. Both products set
  aria-label="View details for X" today, which overrides the content and hides the description,
  the provider, the scopes and the broken-configuration message from screen readers.

Agents (frontend-sw)

• Restyles from MUI to wind: the details go from a dialog with tables to a definition list. The
  dialog itself stays Agents', since the component is content, not a shell.
• The section is a card; unstyled + hideHeader keep the existing SectionAccordion chrome.
• Copy: info and managedMessage take Flow's wording, docsLink becomes "View centralized
  guardrails documentation".

Flow (flow-workbench)

• Read-only values render as text rows rather than greyed, disabled inputs.
• A row with no panel overlay is plain text rather than a disabled button.
• description reuses the builder's "Guardrail description" label; thresholdsFallback keeps
  Flow's plural wording.
• The validator === 'harmful_content' threshold-label branch is replaced by the definition-driven
  label.

Copy and localization

English harvested from both products, in one builder function with the rest of the family. Where
the two agree this package says the same thing; the five places they disagree are declared with
a reason in centralized-parity.test.ts and asserted against both transcriptions, so the suite
fails on an undeclared difference, a stale declaration, or a third wording we invented.

Scope, action, type and description labels reuse the builder's ids, and the provider, BYO and
status chip labels GuardrailList's, rather than declaring guardrails.centralized.* twins, so
they cannot drift from the strings next to them (the builder's are already translated in all
thirteen locales). English only for the ids this block declares itself, like the rest of the
package: chore(l10n): sync from Localization owns the other catalogs.
useSafeLingui renders the English default until it runs, so nothing is blank.

Verification

tsc clean, biome clean on the changed files. Guardrails directory: 31 files, 640 tests
passing, with jest-axe on both rendering suites.

Review questions

1. The status chip is an addition. Both products' centralized sections show only the
   remediation sentence. It is GuardrailList's chip, so the two sections mark a broken
   configuration the same way; if you would rather the row stayed at parity, removing it is one
   &&.
2. Reusing the builder's and the list's ids saves fourteen duplicate strings and keeps them
   from drifting, but it does couple the label blocks.
3. findCentralizedBuiltInDefinition is new. Neither product looks a built-in definition up
   today; it exists only so the configuration rows can be labelled and the entities named. It never
   feeds the display name or description, because a policy can enforce a validator the tenant has
   no definition for.

🤖 Generated with Claude Code

[github-actions]

Apollo Coded App preview deployments are ready.

Project	Status	Preview	Updated (PT)
apollo-design	Ready	Preview · Logs	Sep 23, 2026, 02:42:34 AM
apollo-docs	Ready	Preview · Logs	Sep 23, 2026, 02:42:34 AM
apollo-landing	Ready	Preview · Logs	Sep 23, 2026, 02:42:34 AM
apollo-vertex	Ready	Preview · Logs	Sep 23, 2026, 02:42:34 AM

[github-actions]

Dependency License Review

• ✅ 1937 package(s) scanned
• ✅ No license issues found
• ⚠️ 2 package(s) excluded (see details below)

License distribution

License	Packages
MIT	1708
ISC	88
Apache-2.0	55
BSD-3-Clause	27
BSD-2-Clause	23
BlueOak-1.0.0	8
MPL-2.0	4
MIT-0	3
CC0-1.0	3
MIT OR Apache-2.0	2
(MIT OR Apache-2.0)	2
Unlicense	2
LGPL-3.0-or-later	1
Python-2.0	1
CC-BY-4.0	1
(MPL-2.0 OR Apache-2.0)	1
Unknown	1
Artistic-2.0	1
(WTFPL OR MIT)	1
(BSD-2-Clause OR MIT OR Apache-2.0)	1
CC-BY-3.0	1
0BSD	1
(MIT OR CC0-1.0)	1
MIT AND ISC	1

Excluded packages

Package	Version	License	Reason
@img/sharp-libvips-linux-x64	1.3.3	LGPL-3.0-or-later	LGPL pre-built binary, not linked
khroma	2.1.0	Unknown	MIT per GitHub repo, missing license field in package.json

[github-actions]

📦 Dev Packages

🧹 Dev packages cleaned up after PR close.

Last updated: 2026-09-23 08:34:45 PT

[Copilot]

🟡 Changes recommended

Resolve the critical key-collision issue and the two moderate UI rendering issues.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds shared read-only centralized guardrails list and details UI for Apollo React, with definition-aware rendering, localization, status messaging, and host-controlled shells.

Changes:

• Adds centralized guardrail types, utilities, components, and exports.
• Adds read-only sections, details, configuration displays, stories, and documentation.
• Updates form integrations, chat rendering, localization catalogs, tests, and dependencies.

Review findings: Critical (2 votes): guardrail key collisions in centralized-guardrail-utils.ts. Moderate (1 vote each): interactive tooltip nesting in parameter-label.tsx, and unstable renderer identities in chat-message-content.tsx.

File summaries

File	Reviewed change
pnpm-lock.yaml	Dependency lockfile updates
packages/apollo-wind/src/index.ts	Public package exports
packages/apollo-wind/src/components/ui/textarea.tsx	Textarea component
packages/apollo-wind/src/components/ui/select.tsx	Select component
packages/apollo-wind/src/components/ui/info-tooltip.tsx	Info tooltip component
packages/apollo-wind/src/components/ui/info-tooltip.test.tsx	Tooltip tests
packages/apollo-wind/src/components/ui/info-tooltip.stories.tsx	Tooltip stories
packages/apollo-wind/src/components/ui/index.ts	UI exports
packages/apollo-wind/src/components/ui/form-field.tsx	Form field layout and labels
packages/apollo-wind/src/components/ui/form-field.test.tsx	Form field tests
packages/apollo-wind/src/components/forms/validation-converter.ts	Validation conversion
packages/apollo-wind/src/components/forms/validation-converter.test.ts	Validation tests
packages/apollo-wind/src/components/forms/string-list-field.tsx	String-list field
packages/apollo-wind/src/components/forms/schema-serializer.ts	Schema serialization
packages/apollo-wind/src/components/forms/schema-serializer.test.ts	Serialization tests
packages/apollo-wind/src/components/forms/rules-engine.ts	Form rules engine
packages/apollo-wind/src/components/forms/README.md	Forms documentation
packages/apollo-wind/src/components/forms/metadata-form.stories.tsx	Metadata form stories
packages/apollo-wind/src/components/forms/index.ts	Forms exports
packages/apollo-wind/src/components/forms/form-schema.ts	Form schema definitions
packages/apollo-wind/src/components/forms/form-designer.tsx	Form designer
packages/apollo-wind/src/components/forms/demo-mocks.ts	Demo form mocks
packages/apollo-wind/src/components/forms/custom-controls.stories.tsx	Custom control stories
packages/apollo-react/src/test/setup.ts	Test setup
packages/apollo-react/src/material/components/ap-chat/components/message/chat-message-content.tsx	Locale-aware chat rendering
packages/apollo-react/src/material/components/ap-chat/components/message/chat-message-content.test.tsx	Chat rendering tests
packages/apollo-react/src/i18n/index.ts	Internationalization exports
packages/apollo-react/src/canvas/locales/ru.json	Russian translations
packages/apollo-react/src/canvas/components/index.ts	Canvas component exports
packages/apollo-react/src/canvas/components/Guardrails/utils.ts	Guardrail utilities
packages/apollo-react/src/canvas/components/Guardrails/use-metadata-form-bridge.ts	Metadata form bridge
packages/apollo-react/src/canvas/components/Guardrails/types.ts	Guardrail types
packages/apollo-react/src/canvas/components/Guardrails/render-parameter-bridge.tsx	Parameter rendering bridge
packages/apollo-react/src/canvas/components/Guardrails/index.ts	Guardrail exports
packages/apollo-react/src/canvas/components/Guardrails/i18n.test.ts	Localization tests
packages/apollo-react/src/canvas/components/Guardrails/guardrail-form-layout.tsx	Guardrail form layout
packages/apollo-react/src/canvas/components/Guardrails/guardrail-form-layout.test.tsx	Layout tests
packages/apollo-react/src/canvas/components/Guardrails/guardrail-form-layout.stories.tsx	Layout stories
packages/apollo-react/src/canvas/components/Guardrails/definitions-wire.ts	Wire definitions
packages/apollo-react/src/canvas/components/Guardrails/definitions-copy.test.ts	Definition copy tests
packages/apollo-react/src/canvas/components/Guardrails/components/parameter-label.tsx	Parameter labels and tooltips
packages/apollo-react/src/canvas/components/Guardrails/components/mixed-scopes-banner.tsx	Mixed-scopes banner
packages/apollo-react/src/canvas/components/Guardrails/components/mixed-scopes-banner.test.tsx	Banner tests
packages/apollo-react/src/canvas/components/Guardrails/components/map-enum-field.tsx	Enum field mapping
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-status-chip.tsx	Status chip
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-status-chip.test.tsx	Status chip tests
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-status-banner.tsx	Status banner
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-status-banner.test.tsx	Status banner tests
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-scope-selector.tsx	Scope selector
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-chip.tsx	Guardrail chip
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-chip.test.tsx	Guardrail chip tests
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-action-section.tsx	Action section
packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-action-section.test.tsx	Action section tests
packages/apollo-react/src/canvas/components/Guardrails/components/field-shell.tsx	Field shell
packages/apollo-react/src/canvas/components/Guardrails/components/field-shell.test.tsx	Field shell tests
packages/apollo-react/src/canvas/components/Guardrails/components/enum-list-chips-field.tsx	Enum list field
packages/apollo-react/src/canvas/components/Guardrails/components/centralized-guardrail-row.tsx	Centralized guardrail rows
packages/apollo-react/src/canvas/components/Guardrails/components/centralized-guardrail-parameters.tsx	Read-only parameters
packages/apollo-react/src/canvas/components/Guardrails/components/centralized-guardrail-origin-chip.tsx	Origin indicator
packages/apollo-react/src/canvas/components/Guardrails/centralized-types.ts	Centralized guardrail contracts
packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrails-section.tsx	Read-only guardrail section
packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-details.tsx	Guardrail details
packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-details.test.tsx	Details and accessibility tests
packages/apollo-react/src/canvas/components/Guardrails/builder-utils.ts	Builder utilities
packages/apollo-react/src/canvas/components/Guardrails/builder-types.ts	Builder types
packages/apollo-react/src/canvas/components/Guardrails/__fixtures__/definitions-wire.fixtures.ts	Definition fixtures
packages/apollo-react/src/canvas/components/Guardrails/__fixtures__/catalog-coverage.ts	Catalog coverage fixture
packages/apollo-react/package.json	Package metadata and scripts

Review details

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (2)

packages/apollo-react/src/canvas/components/Guardrails/components/parameter-label.tsx:35

• InfoTooltip renders a real <button>, so placing it inside Label creates an interactive labelable descendant and makes clicks on the tooltip ambiguously activate the associated form control. This also contradicts the shared FormFieldLabel pattern, which deliberately renders the tooltip trigger beside the label (packages/apollo-wind/src/components/ui/form-field.tsx:61-69). Keep the tooltip outside the <Label> for the normal field-label path, while retaining the current text-header path.
  packages/apollo-react/src/material/components/ap-chat/components/message/chat-message-content.tsx:35
• getApolloMessageRenderers creates new arrow-function component types on every AutopilotChatMessageContentComponent render. Because the result is used as <ApolloMessageRenderer>, any parent rerender changes the element type and unmounts/remounts the tool-call or tree renderer, resetting local state such as an expanded tool call and losing its DOM state. Define these renderer components at module scope (passing locale as a prop) or memoize a stable renderer table instead of creating component identities during render.

• Files reviewed: 112/113 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package	Coverage	New-line coverage	Packed (gzip)	Unpacked	vs main
@uipath/apollo-core	—	—	42.01 MB	50.16 MB	±0
@uipath/apollo-react	46.2%	84.9% (141/166)	7.73 MB	30.04 MB	+14.6 KB
@uipath/apollo-ui-icons	—	—	2.86 MB	6.96 MB	±0
@uipath/apollo-wind	—	—	469.4 KB	2.96 MB	−13 B
@uipath/ap-chat	85.8%	—	43.90 MB	56.64 MB	+588 B

_{"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.}

[github-actions]

Storybook visual diff

⚠️ Visual changes detected: 7 changed, 14 added (of 464 compared, 443 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Sep 23, 2026, 02:57:47 AM

[Copilot]

🔵 Needs a closer look

Four moderate review findings remain unresolved, covering threshold-map handling, decimal input editing, label/tooltip structure, and chat renderer identity.

Review details

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (4)

Previously missed (2) — in code that hasn't changed since the last review.

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:257

• The has check treats a parameter entry whose value is null/undefined as configured, so the keySource row is consumed even though toThresholdRow has no threshold value to render. A connector payload with { id: 'thresholds', value: undefined } (or null) will therefore hide the selected entities entirely. Check that the value is a plain threshold-map object before adding its keySource to consumedIds (and add a regression test for an explicit empty value).
  packages/apollo-react/src/material/components/ap-chat/components/message/chat-message-content.tsx:210
• getApolloMessageRenderers creates new inline component functions on every render, so the ApolloMessageRenderer type changes whenever this component re-renders. React consequently remounts the tool/tree renderer and loses state such as an expanded ApToolCall; the previously existing test covered this behavior but is removed in this change. Memoize the renderer list by locale (unconditionally, before the early returns) or move these renderer components to module scope so their identity is stable.

packages/apollo-react/src/canvas/components/Guardrails/components/map-enum-field.tsx:74

• Clearing or editing a decimal threshold can be coerced to 0 before the user finishes typing: an empty intermediate value and values such as 0. both pass through Number.parseFloat(...) || 0, immediately replacing the controlled input. This makes ordinary keyboard editing of fractional thresholds unreliable and can persist an unintended zero; retain the in-progress string (or otherwise defer numeric coercion until a complete value is available) and convert it at commit/validation time.
  packages/apollo-react/src/canvas/components/Guardrails/components/parameter-label.tsx:25
• InfoTooltip renders a real <button>, so placing it inside the <label> creates invalid label content and makes clicking the tooltip trigger ambiguously activate the associated control. FormFieldLabel already avoids this by rendering the label and tooltip as siblings; use the same wrapper pattern here while keeping the tooltip inside the text-header branch where no label is rendered.

• Files reviewed: 112/113 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

Three moderate findings remain unresolved around parameter handling, row-key collisions, and the info-button accessible label.

Review details

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (5)

Previously missed (2) — in code that hasn't changed since the last review.

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:261

• valuesById.has(...) only checks that the parameter entry exists, so a map-enum whose value is explicitly null or undefined still consumes its keySource list. That makes a selected entity list render as a threshold row with unset values instead of remaining a standalone value row, contrary to the documented “only when it has a value” rule. Check the stored map value for null/undefined before adding the source id to consumedIds.
  packages/apollo-react/src/canvas/components/Guardrails/components/centralized-guardrail-row.tsx:120
• This comment says the no-handler path renders a disabled button, but the branch immediately below returns a <div> specifically so the row is plain text and not a control. Please update the comment to describe the current behavior; otherwise future changes may incorrectly restore the disabled-button behavior the story and tests reject.

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:47

• executionStage is intentionally an open string and both validator and a BYO name can contain -, so concatenating these fields with - is not collision-safe. For example, a built-in { validator: 'a-b', executionStage: 'c' } and { validator: 'a', executionStage: 'b-c' } produce the same React key, which can trigger duplicate-key warnings and make React reuse the wrong row after a policy update. Encode the validator, stage, origin kind, and BYO name as separate tuple fields instead of delimiter concatenation.

  const origin = guardrail.isByo ? (guardrail.name ?? 'byo') : 'builtin';
  return `${guardrail.validator}-${guardrail.executionStage}-${origin}`;

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrails-section.tsx:114

• This icon-only button uses the full popover body as its accessible name, so a screen reader announces the long policy sentence as the control name instead of identifying the control as “More information.” The wind FormFieldLabel pattern keeps these separate (content versus tooltipAriaLabel); add a localized centralized info-button label and use it for aria-label here while leaving labels.info as the popover content.

                  aria-label={labels.info}

packages/apollo-react/src/canvas/components/Guardrails/components/guardrail-status-chip.tsx:17

• The new success tone is not exercised by the existing parameterized test, which only covers neutral, warning, and error. Since this mapping selects a distinct badgeVariants class, a regression could make the BYO origin/status chip use the wrong styling while the suite remains green; add a success case (and include it in the relevant accessibility render if desired).

• Files reviewed: 112/113 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

One or more issues must be addressed before approval.

Review details

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (4)

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:47

• This key is built by joining unconstrained wire strings with -, so distinct (validator, executionStage, name) tuples can collide (for example a-b + c and a + b-c). If both rows are present, React can reuse the wrong row DOM/state. Encode the tuple rather than using an ambiguous delimiter.

  return `${guardrail.validator}-${guardrail.executionStage}-${origin}`;

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:257

• valuesById.has() is also true when the connector sends a map parameter with value: null or value: undefined. That makes this consume the keySource list and toThresholdRow renders selected entities with —, whereas an unset map should leave the entity-list row visible (the same behavior as when the map parameter is absent). Check that the map value is non-null/defined before adding its key source to consumedIds.

      parameterDefinition.keySource !== undefined &&
      valuesById.has(parameterDefinition.id) &&
      rendersAsThresholds(parameterDefinition.id)

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrails-section.tsx:52

• When a translation or labels.policyCaption omits {{policyName}}, split returns only the full template and after is undefined, so the emphasized policy name is rendered nowhere even though the comment says it is appended. This can hide which governance policy is enforcing the section; preserve all token occurrences and append the name as a fallback when the token is absent.

  const [before, after] = template.split('{{policyName}}');

packages/apollo-react/src/material/components/ap-chat/components/message/chat-message-content.tsx:38

• getApolloMessageRenderers now creates new inline component functions on every render. Because the selected function is rendered as <ApolloMessageRenderer>, any parent/context/message update changes its React type and remounts tool-call/tree content, resetting local state such as an expanded ApToolCall. Keep these renderer component identities stable, for example by memoizing the list by locale at a hook-safe location or by moving the wrappers to module scope.

• Files reviewed: 112/113 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

Two moderate correctness issues remain in centralized guardrail handling, and the stale accessibility comment should be updated.

Review details

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (3)

Previously missed (1) — in code that hasn't changed since the last review.

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:276

• An empty threshold map ({} or null) should leave its keySource list as a normal value row, but this presence check consumes that list and toThresholdRow unconditionally imports the selected keys into an all-unset threshold table. This contradicts the comment above that only a map with a value should absorb the list; gate both consumption and key-source import on at least one numeric map entry.

packages/apollo-react/src/canvas/components/Guardrails/centralized-guardrail-utils.ts:46

• The key does not encode the origin type, so a valid BYO configuration named builtin collides with the built-in row for the same validator and execution stage (...-builtin). Policies can contain both origins for one validator, so React will warn about duplicate keys and reuse one row's state instead of rendering both. Prefix the BYO portion (for example, byo:${guardrail.name ?? 'byo'}) before composing the key.

  const origin = guardrail.isByo ? (guardrail.name ?? 'byo') : 'builtin';

packages/apollo-react/src/canvas/components/Guardrails/components/centralized-guardrail-row.tsx:123

• This comment describes the old disabled-button behavior, but the implementation immediately below intentionally returns a plain <div> when there is no onSelect (and the story documents that behavior). The contradiction can mislead future changes about the accessibility contract; update the comment to explain that non-interactive rows are plain content and are not announced as unavailable.

  // A row with nowhere to go is not a control. Both products render a disabled button there,
  // which takes it out of the tab order anyway and announces it as unavailable rather than as
  // the plain text it actually is.

• Files reviewed: 112/113 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Copilot review overview

🔵 Needs a closer look

The parameter resolver can silently drop malformed scalar values, and generated row keys can collide for valid wire strings.

Review effort: Lite
Findings: 1 · 4

Open (5)

• The key is built by concatenating unescaped wire values, so distinct guardrails can collide: for…
• parameterType is explicitly unvalidated, but this predicate still trusts it. A BYO value such as…
• This name is a flex item beside the origin/status chips, but truncate alone does not let a flex…
• valuesById.has() is true even when a threshold parameter is present with value: null or…
• A BYO record with a missing/null name and a validator such as pii_detection is currently given…

Resolved since last review (1)

• When options.definitions is supplied after a successful fetch, this branch disables the request…

[Copilot]

Copilot review overview

🟡 Changes recommended

Two moderate issues remain in centralized-guardrail-utils.ts involving unsafe label lookup and collision-prone keys.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 5

Open (6)

• The key is built by concatenating unescaped wire values, so distinct guardrails can collide: for…
• Reject inherited or non-string option labels · New
• parameterType is explicitly unvalidated, but this predicate still trusts it. A BYO value such as…
• This name is a flex item beside the origin/status chips, but truncate alone does not let a flex…
• valuesById.has() is true even when a threshold parameter is present with value: null or…
• A BYO record with a missing/null name and a validator such as pii_detection is currently given…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Three moderate findings remain unresolved in parameter resolution, option-label lookup, and host-specific callback typing.

Review effort: Lite
Findings: 1 · 5

Open (6)

• The key is built by concatenating unescaped wire values, so distinct guardrails can collide: for…
• Reject inherited or non-string option labels
• parameterType is explicitly unvalidated, but this predicate still trusts it. A BYO value such as…
• This name is a flex item beside the origin/status chips, but truncate alone does not let a flex…
• valuesById.has() is true even when a threshold parameter is present with value: null or…
• A BYO record with a missing/null name and a validator such as pii_detection is currently given…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Four moderate issues and one nit remain unresolved.

Review effort: Lite
Findings: 1

Open (1)

• This name is a flex item beside the origin/status chips, but truncate alone does not let a flex…

Resolved since last review (5)

• The key is built by concatenating unescaped wire values, so distinct guardrails can collide: for…
• Reject inherited or non-string option labels
• parameterType is explicitly unvalidated, but this predicate still trusts it. A BYO value such as…
• valuesById.has() is true even when a threshold parameter is present with value: null or…
• A BYO record with a missing/null name and a validator such as pii_detection is currently given…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Whitespace-only guardrail names must fall back to the validator ID.

Review effort: Lite
Findings: None

Resolved since last review (1)

• This name is a flex item beside the origin/status chips, but truncate alone does not let a flex…