Skip to content

feat: Add live status banner to ui5 serve#1439

Open
matz3 wants to merge 9 commits into
mainfrom
ui5-serve-console-output
Open

feat: Add live status banner to ui5 serve#1439
matz3 wants to merge 9 commits into
mainfrom
ui5-serve-console-output

Conversation

@matz3

@matz3 matz3 commented Jun 29, 2026

Copy link
Copy Markdown
Member

JIRA: CPOUI5FOUNDATION-1275

@matz3 matz3 requested a review from a team June 29, 2026 18:19
@matz3 matz3 force-pushed the ui5-serve-console-output branch from 166413e to f4284bb Compare June 30, 2026 06:09

@d3xter666 d3xter666 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tried different scenarios with file modifications, deleteions, new files and it seems to be working as expected

@d3xter666 d3xter666 requested a review from a team June 30, 2026 12:02

@RandomByte RandomByte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these we could also tackle in a later follow-up. E.g. moving the implementation into the logger package (if we actually want to do that) is not a top priority for me and might come with extra work since we then need to account for multiple versions of the logger package being in use (which however is a good reason to couple the banner to the Serve-logger implementation)

Comment thread packages/logger/lib/loggers/Serve.js
Comment thread packages/cli/lib/serve/Banner.js
Comment thread packages/cli/lib/serve/render.js Outdated
Comment thread packages/cli/lib/serve/render.js Outdated
Comment thread packages/cli/lib/cli/commands/serve.js
Comment thread packages/cli/lib/cli/commands/serve.js
Comment thread packages/cli/lib/serve/render.js Outdated
Comment thread packages/cli/lib/serve/Banner.js
Comment thread packages/cli/lib/serve/Banner.js
Comment thread packages/cli/lib/serve/Banner.js
@matz3 matz3 force-pushed the ui5-serve-console-output branch from 4e310e6 to c546338 Compare July 1, 2026 15:21
@matz3

matz3 commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

I applied some changes, especially improvements in the rendering (more compact), and using the figures packages for unicode symbols with fallback.

More changes will be applied in a follow-up PR, as we already have two other improvements building on top of this PR, which would then be unblocked by merging this now.

@matz3 matz3 requested a review from RandomByte July 1, 2026 15:56
@matz3 matz3 enabled auto-merge (squash) July 1, 2026 16:19
@marianfoo

Copy link
Copy Markdown
Contributor

Just out of curiosity, what would happen if I use cap-plugin-ui5 and serve multiple UI5 Apps at the same time using CAP?
What I see in this PR I can only set output to silent to avoid this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants