Fix Windows-incompatible tests and hook execution

[R0GUEEE]

The test suite previously failed on Windows, and the pluggable hook feature silently never fired there either. This change makes the whole suite pass on Windows while keeping Unix behavior intact.

Approach

• Hook scripts are now run through a POSIX shell (sh) on Windows, where shebang scripts cannot be executed directly by the OS. On Unix, hooks execute directly as before.
• isExecutableFile treats any regular file as a hook on Windows, since Windows has no POSIX executable permission bits. This is what made hooks (and several hook tests) silently no-op before.
• Tests that relied on Unix-only tools (ls, touch, mkdir, printf, /etc/passwd) were rewritten to be platform-neutral:
  • TestExecute uses cmd /c exit 0/1 on Windows, true/false on Unix.
  • TestParsePath symlinks a temp file instead of /etc/passwd.
  • Key-setup tests use os.MkdirAll/os.WriteFile instead of shelling out.
  • Hook test scripts redirect to forward-slash paths (filepath.ToSlash) so they work when run through sh.
  • TestBuildKeygenArgs_DefaultsAndShape computes expected paths with filepath.Join.
  • TestResolveToken uses cmd /c echo on Windows instead of the printf shell builtin.

Note for reviewers

• Hook execution on Windows requires a POSIX sh on PATH (e.g. Git Bash / MSYS / WSL). If none is present, hook scripts fall back to direct execution and report their failure via the existing error path.
• Verified with go build ./..., go vet ./..., and go test ./... (all packages pass), plus an skm.exe --version smoke test.

[Copilot]

Pull request overview

This PR aims to make hook execution and the Go test suite behave correctly on Windows, while preserving Unix behavior—primarily by adjusting hook executability detection/dispatch and rewriting several tests to avoid Unix-only dependencies.

Changes:

• Treat hook files as runnable on Windows (no POSIX exec bits) and run shebang hooks via sh when available.
• Refactor multiple tests to use platform-neutral commands and filesystem setup (cmd /c ... on Windows; os.MkdirAll/os.WriteFile instead of shelling out).
• Normalize hook test script paths (e.g., filepath.ToSlash) and expected path construction (filepath.Join) to reduce OS-specific assumptions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
internal/utils/utils.go	Updates hook executability rules on Windows and routes hook execution through sh when present.
internal/utils/utils_test.go	Reworks tests to be platform-neutral and updates hook script generation for Windows/path handling.
internal/publishers/publishers_test.go	Makes CLI fallback token resolution test work on Windows by avoiding POSIX printf.
internal/actions/actions_test.go	Uses filepath.Join for expected keygen output paths to match OS-specific separators.

Suppressed comments (2)

internal/utils/utils_test.go:481

• These shell snippets redirect to the log file without quoting it. If the path contains spaces, the hook will fail when run via sh (common on Windows). Quote the redirection target.

	writeGlobal := "#!/bin/sh\necho G $SKM_EVENT $SKM_ALIAS >> " + logSlash + "\n"
	writePerKey := "#!/bin/sh\necho K $SKM_EVENT $SKM_ALIAS >> " + logSlash + "\n"

internal/utils/utils_test.go:568

• This hook body redirects to the log file without quoting the path, which can fail when the temp/store path contains spaces. Quote the redirection target so the test is robust across platforms.

	body := "#!/bin/sh\necho \"$SKM_REMOTE_HOST $SKM_REMOTE_PORT\" >> " + filepath.ToSlash(log) + "\n"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.