Repository navigation
Use glotter2-core package - #79
Merged
Merged
Conversation
jrg94
approved these changes
Mar 2, 2026
jrg94
left a comment
jrg94
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Looks like a lot of work went into reworking the tests. Thanks for taking the time to do this and sneaking in a few "quality of life" changes as well.
Member
There was a problem hiding this comment.
Thanks for updating this in passing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed #78
Changes in this PR:
Projectclass constructor to useCoreProjectclass from glotter2-coreLanguageCollectionclass constructor to useCoreLanguageclass from glotter2-coreLanguageCollection.testinfoandLanguageCollection.untestable_infomethods now returnTestInfoclass object from glotter2-coreSampleProgramclass constructor to useCoreSourceclass from glotter2-core*in the language name are no longer escaped with backslashlogging.debuginstead oflogging.infoAlso in this PR:
2.3.2