Repository navigation
Conversation
ViCppDev
requested review from
Panquesito7 and
realstealthninja
as code owners
October 5, 2026 14:10
realstealthninja
requested changes
Oct 6, 2026
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Author
|
i've tested code on Debian and Arch Linux latest versions (13.7 for Debian and 2026.10.1 release with kernel version 7.2.7) |
replace if statements with a single return statement
make a function constexpr and inline
replace std::endl with \n in volume.cpp
Author
|
i've tested every change with both clang++ and g++ ; in both debug mode (-g) and release mode (-O3) with C++17 (-std=c++17) |
Collaborator
|
Multiple files are modified in this pull request please remove the other files and only submit one at a time. |
Author
|
alright, i don't think there is a way to delete the files, or at least i don't know how |
Collaborator
It's fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
Notes:
changes in bit_manipulation/count_bits_flip.cpp: