Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #297.
After
SimpleAgent.cleanup()closes configured toolkit resources, a laterbuild()currently keeps the old discovered tool callbacks. A customized toolkit that opens a file reproduces a successful first tool invocation followed by an I/O-on-closed-file error after rebuilding.Preserve the constructor-supplied tools reference and restore it after successful cleanup. Discovered tools are rebuilt from configuration on the next build; explicit caller-owned tools retain their list and tool identities.
Validation
A broader offline selection has eight existing failures, reproduced with unchanged main source: missing generated configuration or required configuration values, and reasoning-converter tests calling an absent helper. The two new resource regressions fail on main and pass with this change. Target-file mypy diagnostics are unchanged (seven existing errors). Full-suite and live-provider validation are not claimed.