Skip to content

fix: harden orchestrator parsing defaults - #289

Open
Jackkp0t wants to merge 1 commit into
TencentCloudADP:mainfrom
Jackkp0t:fix/issue-261-defensive-parsing
Open

Jackkp0t wants to merge 1 commit into
TencentCloudADP:mainfrom
Jackkp0t:fix/issue-261-defensive-parsing

Conversation

@Jackkp0t

Copy link
Copy Markdown

Fixes #261\n\n## What changed\n- Guard the orchestrator plan regex match so malformed or truncated responses reach the existing clear validation error instead of raising AttributeError.\n- Make TaskRecorder.input default to an empty list, matching its declared type and downstream usage.\n- Add focused regression tests for both cases.\n\n## Validation\n- uv run pytest tests/agents/test_orchestrator_chain.py -q\n- uv run ruff check utu/agents/orchestrator/chain.py utu/agents/common.py tests/agents/test_orchestrator_chain.py

@Jackkp0t

Jackkp0t commented Nov 1, 2026

Copy link
Copy Markdown
Author

Hi maintainers, the Tests run for this PR (35722685601) says it required approval but expired before being approved, and its job list is empty. Could you help retrigger and approve the tests for this defensive-parsing fix? I can update the branch if necessary. Thank you.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two small bugs: ChainPlanner._parse crashes on missing <plan> block; TaskRecorder.input wrong default_factory

1 participant