fix: prevent statement regex from matching whitespace-only lines - #31
Merged
Merged
Conversation
A line consisting of only a statement delimiter followed by two or more spaces (e.g., `% `) was being incorrectly parsed as a statement line instead of a statement block start. This occurred because the regex engine backtracked into the greedy `[[:blank:]]+` quantifier to satisfy the `(.+)` requirement of the statement body. Updated `STATEMENT_REGEX` to require at least one non-blank character after the delimiter and space prefix (`[^[:blank:]].*`). Also added corresponding test cases to the regex test suite to prevent future regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line consisting of only a statement delimiter followed by two or more spaces (e.g.,
%) was being incorrectly parsed as a statement line instead of a statement block start. This occurred because the regex engine backtracked into the greedy[[:blank:]]+quantifier to satisfy the(.+)requirement of the statement body.Updated
STATEMENT_REGEXto require at least one non-blank character after the delimiter and space prefix ([^[:blank:]].*). Also added corresponding test cases to the regex test suite to prevent future regressions.Fixes #29
cc: @atsag