chore: remove dead code and shrink over-engineered utilities (-390 lines)

[chefmatteo]

Summary

• Delete ServiceRegistry — built Dio clients that were never accessed; GetIt already owns them via DioFactory
• Delete shared/deprecation.py — add_deprecation_middleware was never wired to any prod route; only existed in tests
• Shrink shared/query_migration.py 159 → 18 lines — only check_deprecated_params had a caller; dead functions removed
• Delete community_post_operations.py / community_comment_operations.py — pure mixin-composition stubs (class X(Read, Write): pass); callers now import the read/write classes directly
• Delete routes/posts.py aggregator — both post routers now included directly in main.py
• Remove PaginatedResponse / DataResponse aliases in contracts.py — no callers anywhere

Test plan

• backend/community-backend/tests/test_operations_units.py — updated imports, same test logic
• Run community-backend: python run.py --service community and confirm /api/v1/posts and /api/v1/feed still respond
• Run activity-backend: confirm check_deprecated_params still works on list endpoints
• Flutter: flutter analyze to confirm no missing imports

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added a weather snapshot API endpoint (POST /api/v1/weather/snapshot) and associated weather data models.
  • Implemented weather caching to speed up repeated lookups.

• Bug Fixes

  • Improved GPS permission flow, messaging, and safety when permission/context is denied.
  • Weather lookup now avoids live GPS access when location permission isn’t available, falling back to cached results.

• Documentation

  • Updated API and service docs with the new weather surface and Open-Meteo/weather cache configuration.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: edfbd165-0224-4948-8e80-df5202e3b24f

📥 Commits

Reviewing files that changed from the base of the PR and between 8a74431 and ba3263e.

📒 Files selected for processing (10)

• backend/main-backend/README.md
• backend/main-backend/app/core/config.py
• backend/main-backend/app/schemas/weather.py
• backend/main-backend/app/services/weather.py
• backend/main-backend/app/services/weather_cache.py
• backend/main-backend/tests/test_weather.py
• backend/shared/query_migration.py
• frontend/ios/Runner/Info.plist
• frontend/lib/services/location_service.dart
• packages/shared/openapi/openapi-main-weather.json

---

📝 Walkthrough

Walkthrough

Adds weather snapshot schemas, Redis caching, backend API wiring, and frontend location-gated fallback handling with updated docs and config. It also splits community post routing, removes frontend ServiceRegistry setup, and trims shared legacy helpers.

Changes

Weather snapshot feature

Layer / File(s)	Summary
Schemas and payload contract backend/main-backend/app/schemas/*, packages/shared/openapi/openapi-main-weather.json	Weather location, snapshot, request, and response schemas are added and re-exported, and the shared payload JSON matches the nested snapshot shape.
Configuration and docs backend/main-backend/app/core/config.py, backend/main-backend/.env.example, backend/main-backend/README.md, backend/README.md, docs/service-ownership.md, backend/docker-compose.yml	Open-Meteo and weather-cache settings are added, and the weather endpoint, ownership, service overview, and Redis env entry are documented.
Redis cache backend/main-backend/app/services/weather_cache.py	The cache adds Redis-backed lookup, write, deserialization, keying, distance validation, and client lifecycle handling for weather snapshots.
Weather snapshot service backend/main-backend/app/services/weather.py	The service fetches Open-Meteo forecasts, uses the cache, normalizes condition, temperature, wind, and precipitation data, and returns WeatherSnapshotResponse.
API and app wiring backend/main-backend/app/api/v1/__init__.py, backend/main-backend/app/api/v1/weather.py, backend/main-backend/app/services/__init__.py, backend/main-backend/app/main.py	The /api/v1/weather router is included, POST /weather/snapshot delegates to weather_service.build_snapshot, and WeatherServiceError becomes a 503.
Location access and weather fallback frontend/lib/services/location_service.dart, frontend/lib/screens/home/location_permission_dialog.dart, frontend/lib/features/activities/data/activities_context_repository.dart, frontend/ios/Runner/Info.plist	Location access checks, permission handling, cached-weather fallback, and iOS usage descriptions are added around the weather flow.
Weather endpoint and cache tests backend/main-backend/tests/test_weather.py	Endpoint contract, validation, integration, and cache-behavior tests cover the weather snapshot request and Redis cache reuse.

Community read/write split

Layer / File(s)	Summary
Split operation bases backend/community-backend/services/supabase_client.py, backend/community-backend/tests/test_operations_units.py	CommunitySupabaseClient and the unit test harness switch from combined post/comment operation bases to separate read/write classes.
Split posts router mounts backend/community-backend/main.py	/api/v1/posts is mounted through separate read and write routers instead of a single combined mount.

Frontend service locator cleanup

Layer / File(s)	Summary
Remove ServiceRegistry from setup frontend/lib/core/di/service_locator.dart	setupServiceLocatorWithEnvironment no longer imports or calls ServiceRegistry, and continues with token-store and client registration directly.

Shared legacy helper cleanup

Layer / File(s)	Summary
Trim shared compatibility helpers backend/shared/contracts.py, backend/shared/query_migration.py	Shared response aliases are removed, and check_deprecated_params now uses the reduced query-migration mapping.

Sequence Diagram(s)

sequenceDiagram
  participant get_weather_snapshot
  participant weather_service
  participant RedisWeatherCache
  participant OpenMeteoAPI
  get_weather_snapshot->>weather_service: build_snapshot(request)
  weather_service->>RedisWeatherCache: get(request)
  RedisWeatherCache-->>weather_service: cached response or none
  weather_service->>OpenMeteoAPI: GET /forecast
  OpenMeteoAPI-->>weather_service: forecast payload
  weather_service->>RedisWeatherCache: set(request, response)
  weather_service-->>get_weather_snapshot: WeatherSnapshotResponse

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

🐇 I sniffed the rain and cached the breeze,
split the paths with gentle ease.
Weather glows on screen and wire,
old helpers hop out of the mire,
carrots and clouds now harmonize.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the PR’s main theme: removing dead code and simplifying over-engineered utilities.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/remove-dead-code

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 markdownlint-cli2 (0.22.1)

backend/main-backend/README.md

markdownlint-cli2 wrapper config was not available before execution

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 11

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@backend/main-backend/app/core/config.py`:
- Around line 53-60: The weather timeout and cache settings are not being
validated when the config model loads, so invalid values can slip through to
WeatherService and RedisWeatherCache.from_settings(). Add validation on the
settings class fields for open_meteo_timeout_seconds, weather_cache_ttl_seconds,
and weather_cache_distance_threshold to reject zero or negative values at load
time, using the existing config model identifiers in app/core/config.py.

In `@backend/main-backend/app/schemas/weather.py`:
- Around line 11-12: Add boundary validation to the Weather request schema so
invalid coordinates fail fast with a 422 instead of reaching the provider
lookup. Update the latitude and longitude fields in the Weather model to enforce
the valid ranges [-90, 90] and [-180, 180], using the existing schema definition
in weather.py so get_weather_snapshot() only receives validated coordinates.

In `@backend/main-backend/app/services/weather_cache.py`:
- Around line 114-120: The cache hit path in WeatherCache is reusing a full
WeatherSnapshotResponse, which can leak request-specific Strava temperature
values from a previous request. Update the WeatherCache response-building logic
to either cache only provider-derived weather data or, when returning a hit,
rebuild the snapshot with the current request’s strava_reported_celsius while
keeping the cached provider fields from cached.response.weather_snapshot. Use
the WeatherCache service flow and WeatherSnapshotResponse construction to locate
the fix.

In `@backend/main-backend/app/services/weather.py`:
- Around line 90-99: The weather provider response parsing in WeatherService
should treat malformed JSON as a provider-side error instead of letting it
escape as an unhandled exception. Update the fetch flow around the httpx.get,
response.raise_for_status, and response.json call in the weather service so that
ValueError/JSONDecodeError from response.json() is caught and converted into
WeatherServiceError, alongside the existing HTTPStatusError and HTTPError
handling, using the same WeatherServiceError path and logger.exception context
in the weather.py service.
- Around line 274-281: The _epoch_or_iso_to_utc helper in WeatherService
currently converts offset-less ISO timestamps via astimezone(UTC), which makes
naive datetimes follow the host timezone. Update the datetime parsing path in
_epoch_or_iso_to_utc so that when datetime.fromisoformat returns a value with
dt.tzinfo is None, it is treated as UTC by attaching UTC before conversion; keep
the existing handling for epoch strings and already-aware timestamps unchanged.

In `@backend/main-backend/README.md`:
- Around line 128-129: Add the missing WEATHER_CACHE_* environment variables to
the README settings list alongside the existing OPENMETEO_* entries, including
WEATHER_CACHE_ENABLED, WEATHER_CACHE_REDIS_URL, WEATHER_CACHE_NAMESPACE,
WEATHER_CACHE_TTL_SECONDS, and WEATHER_CACHE_DISTANCE_THRESHOLD, so the
configuration section in README reflects what the service actually reads.

In `@backend/main-backend/tests/test_weather.py`:
- Around line 102-121: The `test_weather_snapshot_integration_call_real_api`
test currently hits the live Open-Meteo service unconditionally, which makes CI
flaky. Update this test to either require an explicit integration marker or env
flag before calling `weather_service.build_snapshot`, or swap it to use a
stubbed/mocked provider response so it no longer depends on network or provider
uptime. Keep the change localized to the
`test_weather_snapshot_integration_call_real_api` flow and related weather test
setup.

In `@backend/shared/query_migration.py`:
- Line 7: The deprecated-name mapping in query_migration should not treat
activity_type as legacy because the /me route uses it as the active filter and
passes it through list_user_activities. Update the mapping in query_migration so
activity_type is removed from the deprecated-name set, keeping only the truly
old aliases like entity_type and kind, and make sure the route’s current filter
name remains unaffected.

In `@frontend/ios/Runner/Info.plist`:
- Around line 27-36: Remove the duplicated plist entries from Info.plist instead
of re-declaring them here. Keep the location permission keys only once, and
update the existing NSLocationAlwaysAndWhenInUseUsageDescription and
NSLocationWhenInUseUsageDescription values in the later section so the new
weather-related copy is the one iOS uses.

In `@frontend/lib/services/location_service.dart`:
- Around line 19-37: Update hasLocationAccess() in LocationService to match the
dual-source permission logic used by checkPermissions(), since it currently only
consults Geolocator and can disagree with Permission.location.status. Add the
same permission-source check before returning true so
ActivitiesContextRepository.getLocalWeather() only treats location as available
when both sources are aligned, and keep the existing service-enabled check after
that.

In `@packages/shared/openapi/openapi-main-weather.json`:
- Around line 4-14: Update the shared weather example to match the actual
WeatherService.build_snapshot contract. Replace the outdated OpenWeather/Strava
fields in the openapi example with the runtime shape returned by
WeatherService.build_snapshot, especially the source value (“Open-Meteo”) and
any provider-specific snapshot details such as condition code/icon URL. Keep the
example consistent with the actual response schema so consumers using this
mock/shared contract see the same payload that the service returns.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e47cbf2a-fa3c-4d5e-a922-fe2a66f83968

📥 Commits

Reviewing files that changed from the base of the PR and between d1589f7 and 8a74431.

📒 Files selected for processing (32)

• backend/README.md
• backend/community-backend/main.py
• backend/community-backend/routes/posts.py
• backend/community-backend/services/community_comment_operations.py
• backend/community-backend/services/community_post_operations.py
• backend/community-backend/services/supabase_client.py
• backend/community-backend/tests/test_operations_units.py
• backend/docker-compose.yml
• backend/main-backend/.env.example
• backend/main-backend/README.md
• backend/main-backend/app/api/v1/__init__.py
• backend/main-backend/app/api/v1/weather.py
• backend/main-backend/app/core/config.py
• backend/main-backend/app/main.py
• backend/main-backend/app/schemas/__init__.py
• backend/main-backend/app/schemas/weather.py
• backend/main-backend/app/services/__init__.py
• backend/main-backend/app/services/weather.py
• backend/main-backend/app/services/weather_cache.py
• backend/main-backend/tests/test_weather.py
• backend/shared/contracts.py
• backend/shared/deprecation.py
• backend/shared/query_migration.py
• backend/tests/test_deprecation_middleware.py
• docs/service-ownership.md
• frontend/ios/Runner/Info.plist
• frontend/lib/core/di/service_locator.dart
• frontend/lib/features/activities/data/activities_context_repository.dart
• frontend/lib/screens/home/location_permission_dialog.dart
• frontend/lib/services/location_service.dart
• frontend/lib/services/service_registry.dart
• packages/shared/openapi/openapi-main-weather.json

💤 Files with no reviewable changes (8)

• backend/community-backend/services/community_post_operations.py
• backend/community-backend/services/community_comment_operations.py
• backend/shared/deprecation.py
• backend/tests/test_deprecation_middleware.py
• backend/community-backend/routes/posts.py
• frontend/lib/core/di/service_locator.dart
• frontend/lib/services/service_registry.dart
• backend/shared/contracts.py